8271869: AArch64: build errors with GCC11 in frame::saved_oop_result #5020
Conversation
GCC11 warns that r0 is null. It does not complain if r1 is used instead. AIUI, it is undefined behaviour in C++ to call member functions without a valid this pointer. So, technically GCC is correct to warn.
|
👋 Welcome back a74nh! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
This looks ok to me as it's the same workaround as JDK-8270083 but @kimbarrett probably ought check it too.
|
@a74nh This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nick-arm, @theRealAph) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Yuck! But I guess we don't have any other quick solution to supporting this compiler version, so as with JDK-8270083 I'm conditionally approving this as a temporary workaround. I see this bug is already linked to JDK-8270140. @theRealAph - You mentioned a prototype patch to fix the register definitions (probably addressing JDK-8270140?). How close are you on that? Do you need any help? |
Ok - that explains why the errors I saw were only in AArch64 files. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 1f88134.
Your commit was automatically rebased without conflicts. |
openjdk
bot
added
integrated
|
On 8/10/21 8:41 AM, Kim Barrett wrote:
Yes, it fixes that by making Register well-defined behaviour.
The patch works just fine, but there is a smallish performance |
|
Mailing list message from Andrew Haley on hotspot-dev: On 8/5/21 3:21 PM, Alan Hayward wrote:
Correct. I have a prototype patch to fix this, but the same undefined I will approve this now if you really need it, but I wonder if Andrew. -- |
|
Mailing list message from Andrew Haley on hotspot-dev: On 8/10/21 8:41 AM, Kim Barrett wrote:
Yes, it fixes that by making Register well-defined behaviour.
The patch works just fine, but there is a smallish performance -- |
GCC11 warns that r0 is null. It does not complain if r1 is used instead.
AIUI, it is undefined behaviour in C++ to call member functions without
a valid this pointer. So, technically GCC is correct to warn.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5020/head:pull/5020$ git checkout pull/5020Update a local copy of the PR:
$ git checkout pull/5020$ git pull https://git.openjdk.java.net/jdk pull/5020/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5020View PR using the GUI difftool:
$ git pr show -t 5020Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5020.diff