Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272067: Initial nroff manpage generation for JDK 18 #5028

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 6, 2021

Please review this trivial update to the generated manpages that updates their version from "JDK 17" to "JDK 18-ea".

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272067: Initial nroff manpage generation for JDK 18

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5028/head:pull/5028
$ git checkout pull/5028

Update a local copy of the PR:
$ git checkout pull/5028
$ git pull https://git.openjdk.java.net/jdk pull/5028/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5028

View PR using the GUI difftool:
$ git pr show -t 5028

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5028.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 6, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@dholmes-ora The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc serviceability core-libs compiler kulla hotspot-jfr labels Aug 6, 2021
@dholmes-ora dholmes-ora closed this Aug 6, 2021
@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Aug 6, 2021

/label remove compiler core-libs hotspot-jfr kulla serviceability javadoc

@openjdk openjdk bot removed compiler core-libs hotspot-jfr kulla serviceability javadoc labels Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@dholmes-ora
The compiler label was successfully removed.

The core-libs label was successfully removed.

The hotspot-jfr label was successfully removed.

The kulla label was successfully removed.

The serviceability label was successfully removed.

The javadoc label was successfully removed.

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Aug 6, 2021

/label add build

@dholmes-ora dholmes-ora reopened this Aug 6, 2021
@openjdk openjdk bot added the build label Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@dholmes-ora
The build label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 6, 2021

Webrevs

jddarcy
jddarcy approved these changes Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272067: Initial nroff manpage generation for JDK 18

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • adb0ae5: 8261441: JFR: Filename expansion
  • e38e365: 8271208: Typo in ModuleDescriptor.read javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 6, 2021
@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Aug 6, 2021

Thanks for the review @jddarcy!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

Going to push as commit ea02dad.
Since your change was applied there have been 2 commits pushed to the master branch:

  • adb0ae5: 8261441: JFR: Filename expansion
  • e38e365: 8271208: Typo in ModuleDescriptor.read javadoc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 6, 2021
@dholmes-ora dholmes-ora deleted the 8272067-manpage branch Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@dholmes-ora Pushed as commit ea02dad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants