8271946: Cleanup leftovers in Space and subclasses

[rkennke]

There are a number of methods in (Compactible)Space that seem trivially implemented. E.g. obj_size(), adjust_obj_size(), scanned_block_is_obj() etc. I believe they are leftovers from CMS (not sure) but looks like they can be replaced by obj->size() or removed altogether. Also, the the related templated methods scan_and_forward(), scan_and_adjust_pointers() and scan_and_compact() can be directly and mechanically inlined into their callers. It makes the code more readable.

Testing:

• hotspot_gc
• tier1
• tier2

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271946: Cleanup leftovers in Space and subclasses

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5031/head:pull/5031
$ git checkout pull/5031

Update a local copy of the PR:
$ git checkout pull/5031
$ git pull https://git.openjdk.java.net/jdk pull/5031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5031

View PR using the GUI difftool:
$ git pr show -t 5031

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5031.diff

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkennke The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ebaa84b8)
• 00: Full (41fe28ea)

[stefank]

The entire surrounding comment needs to be updated now that these functions have been removed.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271946: Cleanup leftovers in Space and subclasses

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

• db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
• a81e5e9: 8272654: Mark word accesses should not use Access API
• 4bd37c3: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
• ddcd851: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
• d007be0: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
• f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
• b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
• 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
• 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
• ... and 134 more: https://git.openjdk.java.net/jdk/compare/685fc3c677cd0e71ef4443214ae14c7eed355140...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

Ping? Anybody else who wants to approve this? Thanks!

[tschatzl]

Lgtm.

[rkennke]

/integrate

[openjdk]

Going to push as commit 92bde67.
Since your change was applied there have been 144 commits pushed to the master branch:

• db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
• a81e5e9: 8272654: Mark word accesses should not use Access API
• 4bd37c3: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
• ddcd851: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
• d007be0: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
• f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
• b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
• 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
• 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
• ... and 134 more: https://git.openjdk.java.net/jdk/compare/685fc3c677cd0e71ef4443214ae14c7eed355140...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rkennke Pushed as commit 92bde67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.