Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 #5032

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 6, 2021

A trivial fix to ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5032/head:pull/5032
$ git checkout pull/5032

Update a local copy of the PR:
$ git checkout pull/5032
$ git pull https://git.openjdk.java.net/jdk pull/5032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5032

View PR using the GUI difftool:
$ git pr show -t 5032

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5032.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 6, 2021 13:33
@AlanBateman
Copy link
Contributor

/label add nio

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated core-libs core-libs-dev@openjdk.org labels Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@AlanBateman - Thanks for the fast review!

/integrate

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@AlanBateman
The nio label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 6, 2021

Going to push as commit f4cf2f7.

@openjdk openjdk bot closed this Aug 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2021
@openjdk
Copy link

openjdk bot commented Aug 6, 2021

@dcubed-ojdk Pushed as commit f4cf2f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Aug 6, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8272095 branch August 6, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants