-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8264792: The NumberFormat for locale sq_XK formats price incorrectly. #5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 41dc795.
Your commit was automatically rebased without conflicts. |
Please review the fix to the subject issue. The root cause of this problem is that the currency for the country code
XK
is undefined because the country code is user-defined in the ISO 3166 standard. However, it is commonly used to represent the regionKosovo
, which CLDR supports and subsequently is supported by the JDK since JDK9. Adding the dataEUR
for the country codeXK
will fix the issue.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5033/head:pull/5033
$ git checkout pull/5033
Update a local copy of the PR:
$ git checkout pull/5033
$ git pull https://git.openjdk.java.net/jdk pull/5033/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5033
View PR using the GUI difftool:
$ git pr show -t 5033
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5033.diff