Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264792: The NumberFormat for locale sq_XK formats price incorrectly. #5033

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Aug 6, 2021

Please review the fix to the subject issue. The root cause of this problem is that the currency for the country code XK is undefined because the country code is user-defined in the ISO 3166 standard. However, it is commonly used to represent the region Kosovo, which CLDR supports and subsequently is supported by the JDK since JDK9. Adding the data EUR for the country code XK will fix the issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264792: The NumberFormat for locale sq_XK formats price incorrectly.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5033/head:pull/5033
$ git checkout pull/5033

Update a local copy of the PR:
$ git checkout pull/5033
$ git pull https://git.openjdk.java.net/jdk pull/5033/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5033

View PR using the GUI difftool:
$ git pr show -t 5033

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5033.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 6, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build core-libs i18n labels Aug 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 6, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264792: The NumberFormat for locale sq_XK formats price incorrectly.

Reviewed-by: joehw, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • c495ede: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • e882087: 8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags
  • fa36e33: 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator
  • cc61520: 8270842: G1: Only young regions need to redirty outside references in remset.
  • f4cf2f7: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • 0aca4f7: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • b6a19f1: 8271128: InlineIntrinsics support for 32-bit ARM
  • c2b7fac: 8271896: Remove unnecessary top address checks in BOT
  • e7b6f48: 8265602: -XX:DumpLoadedClassList should support custom loaders
  • ea02dad: 8272067: Initial nroff manpage generation for JDK 18
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/62e72adfa7bcc8e2a70c1346f3051deb2488affc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 6, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Aug 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

Going to push as commit 41dc795.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 9c6457f: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 0ac2be9: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
  • 272fcb4: 8272113: Build compare script fails with differences in classlist
  • 2f7a469: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling
  • a86ac0d: 8271939: Clean up primitive raw accessors in oopDesc
  • b84a9c7: 8271956: AArch64: C1 build failed after JDK-8270947
  • 38ff85c: 8271461: CompileCommand support for hidden class methods
  • c495ede: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • e882087: 8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags
  • fa36e33: 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/62e72adfa7bcc8e2a70c1346f3051deb2488affc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@naotoj Pushed as commit 41dc795.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build core-libs i18n integrated
3 participants