8224922: Access JavaFileObject from Element(s) #5038

jddarcy · 2021-08-06T21:12:49Z

Initial review to get some comments on the shape of the API. Tests are needed of course, as well as some tuning of the spec to better describe differences in behavior when class files rather than source files are the backing file type.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8224922: Access JavaFileObject from Element(s)

Reviewers

Jonathan Gibbons (@jonathan-gibbons - Reviewer) ⚠️ Review applies to cd9f6bc

Contributors

Jan Lahoda <jlahoda@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5038/head:pull/5038
$ git checkout pull/5038

Update a local copy of the PR:
$ git checkout pull/5038
$ git pull https://git.openjdk.java.net/jdk pull/5038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5038

View PR using the GUI difftool:
$ git pr show -t 5038

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5038.diff

bridgekeeper · 2021-08-06T21:14:09Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

jddarcy · 2021-08-06T21:14:39Z

/csr needed

openjdk · 2021-08-06T21:15:20Z

@jddarcy this pull request will not be integrated until the CSR request JDK-8272106 for issue JDK-8224922 has been approved.

openjdk · 2021-08-06T21:16:58Z

@jddarcy The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-08-06T21:21:51Z

Webrevs

lahodaj · 2021-08-10T20:48:24Z

Seems useful to me. A possible conversion from Element to FileObject is needed elsewhere as well, I've tried to write it here:

jdk/src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacFiler.java

Line 526 in aa61e59

private JavaFileObject[] originatingFiles(Element[] originatingElements) {

bridgekeeper · 2021-09-07T23:18:16Z

@jddarcy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

jddarcy · 2021-09-07T23:19:05Z

Keep-alive.

bridgekeeper · 2021-10-06T02:49:34Z

@jddarcy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

jddarcy · 2021-10-06T03:13:28Z

Still keep-alive.

Improvements to JDK-8224922

openjdk · 2021-11-02T13:55:29Z

⚠️ @jddarcy This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

…class' FileObject, adding tests for unnamed module/package and automatic modules.

Adding tests for unnamed module/package and automatic modules.

…-8224922

Adding forgotten file/fixing test.

Fixing a test on Windows.

jonathan-gibbons

Nice to see at least partial cleanup of the Symbol.classfile field.

jonathan-gibbons · 2021-11-18T19:28:37Z

src/java.compiler/share/classes/javax/lang/model/element/package-info.java

@@ -36,7 +36,7 @@
 * appearing inside method bodies, such as local variables and
 * anonymous classes.
 *
- * <p>When used in the context of annotation processing, an accurate
+ * <p><a id="accurate_model">When used in the context of annotation processing, an accurate


It would be more correct to just put the id on the <p> tag and drop the <a>.

jonathan-gibbons · 2021-11-18T19:30:07Z

src/java.compiler/share/classes/javax/lang/model/util/Elements.java

+     * (implicitly) created during an annotation processing run from
+     * the creation of source or class files in that package.  An
+     * {@linkplain PackageElement#isUnnamed unnamed package} will have
+     * a null file since it cannot be declared in a compilation unit.


{@code } around null ??

I'll fix these before pushing and do a follow-up pass over the API for consistent "null" vs "{@code null}" treatment.

jonathan-gibbons · 2021-11-18T19:30:26Z

src/java.compiler/share/classes/javax/lang/model/util/Elements.java

+     *
+     * <p>If it has a file object, the file object for a module will
+     * be a {@code module-info} file.  An {@linkplain
+     * ModuleElement#isUnnamed unnamed module} will have a null file


another null.

jonathan-gibbons · 2021-11-18T19:30:55Z

src/java.compiler/share/classes/javax/lang/model/util/Elements.java

+     * ModuleElement#isUnnamed unnamed module} will have a null file
+     * since it cannot be declared in a compilation unit.  An
+     * {@linkplain #isAutomaticModule automatic module} will have a
+     * null file since it is implicitly declared.


I guess you're consistent!

openjdk · 2021-11-18T19:52:35Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8224922: Access JavaFileObject from Element(s)

Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jddarcy · 2021-11-21T20:41:50Z

/integrate

openjdk · 2021-11-21T20:42:54Z

Going to push as commit 4ff4301.

openjdk · 2021-11-21T20:43:05Z

@jddarcy Pushed as commit 4ff4301.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8224922: Access JavaFileObject from Element(s)

7054751

openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Aug 6, 2021

openjdk bot added the compiler compiler-dev@openjdk.org label Aug 6, 2021

Merge branch 'master' into JDK-8224922

e2acf39

lahodaj and others added 14 commits October 22, 2021 15:12

Merge branch 'master' into JDK-8224922

312804b

Attempting to improve Elements.getFileObjectOf

4cf5038

Merge branch 'master' into JDK-8224922

a9a4f36

Fixing behavior for nested classes

d5ae4bd

Merge remote-tracking branch 'JDK-8224922' into JDK-8224922

acecb8f

Attempting to fix tests.

3780012

Merge branch 'master' into JDK-8224922

487f477

Update spec.

9cdb6c9

Merge branch 'master' into JDK-8224922

d1b6fab

Merge remote-tracking branch 'darcy/JDK-8224922' into JDK-8224922

fad7bb5

Cleanup.

f744fe7

Cleanup.

766b9b9

Test cleanup.

b301d92

Merge pull request #3 from lahodaj/JDK-8224922

1584c4b

Improvements to JDK-8224922

jddarcy and others added 12 commits November 15, 2021 23:54

Update spec for unnamed packages and modules.

1d2492d

Adjusting to the specification requiring returning of the outtermost …

7ab409a

…class' FileObject, adding tests for unnamed module/package and automatic modules.

Using a specific class file as the source.

9ca744b

Refine spec.

bc9b6b1

Add explicit spec coverage of auxillary types in package-info files.

cfe2a8f

Refine spec.

8cdbf52

Add spec for automatic modules.

1f5e548

Merge pull request #5 from lahodaj/JDK-8224922-3

be16769

Adding tests for unnamed module/package and automatic modules.

Merge branch 'master' into JDK-8224922

f9c5888

Merge branch 'JDK-8224922' of https://github.com/jddarcy/jdk into JDK…

7f8c7f6

…-8224922

Fix spec typo; update copyrights.

56953b4

Reflow paragraphs.

04e8ea4

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 17, 2021

lahodaj and others added 4 commits November 18, 2021 06:45

Adding forgotten file/fixing test.

4e44aaa

Merge pull request #6 from lahodaj/JDK-8224922-4

a62ff19

Adding forgotten file/fixing test.

Attempting to fix a Windows test.

2b268a2

Merge pull request #7 from lahodaj/JDK-8224922-5

cd9f6bc

Fixing a test on Windows.

jonathan-gibbons approved these changes Nov 18, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2021

jddarcy added 2 commits November 21, 2021 11:46

Merge branch 'master' into JDK-8224922

55759b2

Respond to review feedback.

ff1badb

openjdk bot closed this Nov 21, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2021

jddarcy deleted the JDK-8224922 branch December 9, 2021 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8224922: Access JavaFileObject from Element(s) #5038

8224922: Access JavaFileObject from Element(s) #5038

jddarcy commented Aug 6, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 6, 2021

jddarcy commented Aug 6, 2021

openjdk bot commented Aug 6, 2021

openjdk bot commented Aug 6, 2021

mlbridge bot commented Aug 6, 2021 •

edited

Loading

lahodaj commented Aug 10, 2021

bridgekeeper bot commented Sep 7, 2021

jddarcy commented Sep 7, 2021

bridgekeeper bot commented Oct 6, 2021

jddarcy commented Oct 6, 2021

openjdk bot commented Nov 2, 2021

jonathan-gibbons left a comment •

edited

Loading

jonathan-gibbons Nov 18, 2021

jddarcy Nov 21, 2021

jonathan-gibbons Nov 18, 2021 •

edited

Loading

jddarcy Nov 21, 2021

jonathan-gibbons Nov 18, 2021

jonathan-gibbons Nov 18, 2021

openjdk bot commented Nov 18, 2021 •

edited

Loading

jddarcy commented Nov 21, 2021

openjdk bot commented Nov 21, 2021

openjdk bot commented Nov 21, 2021

8224922: Access JavaFileObject from Element(s) #5038

8224922: Access JavaFileObject from Element(s) #5038

Conversation

jddarcy commented Aug 6, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Contributors

Reviewing

bridgekeeper bot commented Aug 6, 2021

jddarcy commented Aug 6, 2021

openjdk bot commented Aug 6, 2021

openjdk bot commented Aug 6, 2021

mlbridge bot commented Aug 6, 2021 • edited Loading

Webrevs

lahodaj commented Aug 10, 2021

bridgekeeper bot commented Sep 7, 2021

jddarcy commented Sep 7, 2021

bridgekeeper bot commented Oct 6, 2021

jddarcy commented Oct 6, 2021

openjdk bot commented Nov 2, 2021

jonathan-gibbons left a comment • edited Loading

Choose a reason for hiding this comment

jonathan-gibbons Nov 18, 2021

Choose a reason for hiding this comment

jddarcy Nov 21, 2021

Choose a reason for hiding this comment

jonathan-gibbons Nov 18, 2021 • edited Loading

Choose a reason for hiding this comment

jddarcy Nov 21, 2021

Choose a reason for hiding this comment

jonathan-gibbons Nov 18, 2021

Choose a reason for hiding this comment

jonathan-gibbons Nov 18, 2021

Choose a reason for hiding this comment

openjdk bot commented Nov 18, 2021 • edited Loading

jddarcy commented Nov 21, 2021

openjdk bot commented Nov 21, 2021

openjdk bot commented Nov 21, 2021

jddarcy commented Aug 6, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 6, 2021 •

edited

Loading

jonathan-gibbons left a comment •

edited

Loading

jonathan-gibbons Nov 18, 2021 •

edited

Loading

openjdk bot commented Nov 18, 2021 •

edited

Loading