Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 #5044

Closed
wants to merge 2 commits into from
Closed

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Aug 9, 2021

As per the bug comments, these tests fail too often on macOS arm.
This will be too noisy for CI. So I would like to problem list them for mac-arm


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5044/head:pull/5044
$ git checkout pull/5044

Update a local copy of the PR:
$ git checkout pull/5044
$ git pull https://git.openjdk.java.net/jdk pull/5044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5044

View PR using the GUI difftool:
$ git pr show -t 5044

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5044.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prrace
Copy link
Contributor Author

prrace commented Aug 9, 2021

/add swing awt

@prrace
Copy link
Contributor Author

prrace commented Aug 9, 2021

/label awt swing

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace Unknown command add - for a list of valid commands use /help.

@openjdk openjdk bot added awt client-libs-dev@openjdk.org swing client-libs-dev@openjdk.org labels Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace
The awt label was successfully added.

The swing label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 9, 2021

Webrevs

@@ -529,6 +529,7 @@ java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java 8266283 ge
java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java 8257529 windows-x64

java/awt/Window/GetScreenLocation/GetScreenLocationTest.java 8225787 linux-x64
java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java 8252813 macosx-aarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this bug is a closed one, can it be open?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use JDK-8266243 instead. Other one has other tests as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use JDK-8266243 instead. Other one has other tests as well.

I can do that. Somehow my search missed that as an option.

Looks like this bug is a closed one, can it be open?

I think it can be open but it won't be listed here with the changeI just made to reference 8266243

@prrace
Copy link
Contributor Author

prrace commented Aug 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace This PR has not yet been marked as ready for integration.

@prrace prrace changed the title 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 Aug 9, 2021
@prrace
Copy link
Contributor Author

prrace commented Aug 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewed-by: jdv, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 272fcb4: 8272113: Build compare script fails with differences in classlist
  • 2f7a469: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling
  • a86ac0d: 8271939: Clean up primitive raw accessors in oopDesc
  • b84a9c7: 8271956: AArch64: C1 build failed after JDK-8270947

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

Going to push as commit 0ac2be9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 272fcb4: 8272113: Build compare script fails with differences in classlist
  • 2f7a469: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling
  • a86ac0d: 8271939: Clean up primitive raw accessors in oopDesc
  • b84a9c7: 8271956: AArch64: C1 build failed after JDK-8270947

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@prrace Pushed as commit 0ac2be9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated swing client-libs-dev@openjdk.org
4 participants