Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271956: AArch64: C1 build failed after JDK-8270947 #5045

Closed
wants to merge 1 commit into from

Conversation

@shqking
Copy link
Contributor

@shqking shqking commented Aug 9, 2021

C1 build failed on AArch64 with the following error message:

  src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:4642:30: error:
  invalid use of incomplete type 'class CompileTask'

Including the header would fix this error. Note that this header is
included already under COMPILER2 by "opto/compile.hpp".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271956: AArch64: C1 build failed after JDK-8270947

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5045/head:pull/5045
$ git checkout pull/5045

Update a local copy of the PR:
$ git checkout pull/5045
$ git pull https://git.openjdk.java.net/jdk pull/5045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5045

View PR using the GUI difftool:
$ git pr show -t 5045

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5045.diff

C1 build failed on AArch64 with the following error message:
```
  src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp:4642:30: error:
  invalid use of incomplete type 'class CompileTask'
```

Including the header would fix this error. Note that this header is
included already under COMPILER2 by "opto/compile.hpp".
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 9, 2021

👋 Welcome back haosun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@shqking The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Aug 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 9, 2021

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@shqking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271956: AArch64: C1 build failed after JDK-8270947

Reviewed-by: shade, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @nick-arm) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Aug 9, 2021
@shqking
Copy link
Contributor Author

@shqking shqking commented Aug 9, 2021

Thanks for your review. @shipilev and @nick-arm
Since all the pre-submit tests pass with this trivial patch, I suppose it is ready to be merged now.

/integrate

Loading

@openjdk openjdk bot added the sponsor label Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@shqking
Your change (at version 7234e83) is now ready to be sponsored by a Committer.

Loading

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 9, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

Going to push as commit b84a9c7.

Loading

@openjdk openjdk bot closed this Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@shipilev @shqking Pushed as commit b84a9c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shqking shqking deleted the 8271956 branch Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants