Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272146: Disable Fibonacci test on memory constrained systems #5051

Closed
wants to merge 1 commit into from

Conversation

mychris
Copy link
Member

@mychris mychris commented Aug 9, 2021

Hi,

please review this small change to the Fibonacci test case. I added an additional memory requirement for Linux, as I am seeing the test fail on some embedded and emulated devices which do not have enough memory to execute the test case.
The test succeeds on a device with 512MB of physical memory, so I guess this upper bound should be fine. The problem seems to be the kernel memory, as the devices have enough swap space to handle the other test cases.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272146: Disable Fibonacci test on memory constrained systems

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5051/head:pull/5051
$ git checkout pull/5051

Update a local copy of the PR:
$ git checkout pull/5051
$ git pull https://git.openjdk.java.net/jdk pull/5051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5051

View PR using the GUI difftool:
$ git pr show -t 5051

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5051.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 9, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 9, 2021

@mychris The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 9, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems a reasonable constraint.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272146: Disable Fibonacci test on memory constrained systems

Reviewed-by: dholmes, mseledtsov, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 846cc88: 8272138: ZGC: Adopt relaxed ordering for self-healing
  • 5350b99: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 1489352: 8271718: Crash when during color transformation the color profile is replaced
  • 2a9acc3: 8272050: typo in MachSpillCopyNode::implementation after JDK-8131362
  • b62e742: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 66d1faa: 8271601: Math.floorMod(int, int) and Math.floorMod(long, long) differ in their logic
  • 57ae9fb: 8140442: Add getOutermostTypeElement to javax.lang.model utility class
  • 67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • 35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
  • 2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/38ff85c824750e7da66fd86f5bde1c4587e529c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @mseledts, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 10, 2021
@mychris
Copy link
Member Author

@mychris mychris commented Aug 11, 2021

Thanks for the reviews.
/integrate

@openjdk openjdk bot added the sponsor label Aug 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@mychris
Your change (at version bc70256) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 11, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

Going to push as commit adba09b.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 846cc88: 8272138: ZGC: Adopt relaxed ordering for self-healing
  • 5350b99: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 1489352: 8271718: Crash when during color transformation the color profile is replaced
  • 2a9acc3: 8272050: typo in MachSpillCopyNode::implementation after JDK-8131362
  • b62e742: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
  • 66d1faa: 8271601: Math.floorMod(int, int) and Math.floorMod(long, long) differ in their logic
  • 57ae9fb: 8140442: Add getOutermostTypeElement to javax.lang.model utility class
  • 67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
  • 35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
  • 2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/38ff85c824750e7da66fd86f5bde1c4587e529c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@shipilev @mychris Pushed as commit adba09b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
4 participants