Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253475: Javadoc clean up in HttpExchange and HttpServer #506

Closed
wants to merge 6 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Oct 5, 2020

Hi,

Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean up in HttpExchange and HttpServer' ?

This fix is set of formatting changes intended to clean up the javadoc of the following classes :

com.sun.net.httpserver.HttpExchange
com.sun.net.httpserver.HttpServer

This issue is a sub-task of JDK-8252822

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (3/3 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ❌ (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8253475: Javadoc clean up in HttpExchange and HttpServer

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/506/head:pull/506
$ git checkout pull/506

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2020

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2020
@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 5, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2020

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Alternatively you could (if you want) make sure that InputStream and OutputStream are imported and change {@link java.io.XxxxStream} into {@link XxxxStream}.

@openjdk
Copy link

openjdk bot commented Oct 6, 2020

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253475: Javadoc clean up in HttpExchange and HttpServer

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2020
@pconcannon
Copy link
Contributor Author

Thanks @dfuch, that's a good observation. I've incorporated it into commit 6df6ddf

@pconcannon
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2020
@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@pconcannon Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 49128a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants