8272050: typo in MachSpillCopyNode::implementation after JDK-8131362

[dean-long]

After refactoring done by JDK-8131362, the fpr --> fpr case now checks "cbuf" instead of "is64" when it decides between fmovd and fmovs. But since this is register to register, it appears to be harmless.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272050: typo in MachSpillCopyNode::implementation after JDK-8131362

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5060/head:pull/5060
$ git checkout pull/5060

Update a local copy of the PR:
$ git checkout pull/5060
$ git pull https://git.openjdk.java.net/jdk pull/5060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5060

View PR using the GUI difftool:
$ git pr show -t 5060

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5060.diff

[bridgekeeper]

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dean-long The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e46ae9b)

[vnkozlov]

Trivial

[openjdk]

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272050: typo in MachSpillCopyNode::implementation after JDK-8131362

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
• d53d94b: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
• 3b899ef: 8272168: some hotspot runtime/logging tests don't check exit code
• abdc107: 8270454: G1: Simplify region index comparison
• eb6f3fe: 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty
• 9654fd7: 8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dean-long]

Thanks for the reviews, @TobiHartmann and @vnkozlov.

[dean-long]

/integrate

[openjdk]

Going to push as commit 2a9acc3.
Since your change was applied there have been 15 commits pushed to the master branch:

• b62e742: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
• 66d1faa: 8271601: Math.floorMod(int, int) and Math.floorMod(long, long) differ in their logic
• 57ae9fb: 8140442: Add getOutermostTypeElement to javax.lang.model utility class
• 67869b4: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup
• 35b399a: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying
• 2b05fae: 8260262: Use common code in function unmap_shared() in perfMemory_posix.cpp
• f2599ad: 8272196: Remove unused class ParStrongRootsScope
• 1f88134: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result
• 089e83b: 8266490: Extend the OSContainer API to support the pids controller of cgroups
• 2384e12: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/843943c204f6e8ca046919eae4e727bef6e3326c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dean-long Pushed as commit 2a9acc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.