Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272168: some hotspot runtime/logging tests don't check exit code #5062

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Aug 10, 2021

Hi all,

could you please review the patch that adds a check of exit code in five runtime/logging tests?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272168: some hotspot runtime/logging tests don't check exit code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5062/head:pull/5062
$ git checkout pull/5062

Update a local copy of the PR:
$ git checkout pull/5062
$ git pull https://git.openjdk.java.net/jdk pull/5062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5062

View PR using the GUI difftool:
$ git pr show -t 5062

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5062.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8272168 8272168: some hotspot runtime/logging tests don't check exit code Aug 10, 2021
@openjdk openjdk bot added the rfr label Aug 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 10, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Thanks for the update.
LGTM and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272168: some hotspot runtime/logging tests don't check exit code

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 10, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Aug 10, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

Going to push as commit 3b899ef.

@openjdk openjdk bot closed this Aug 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

@iignatev Pushed as commit 3b899ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8272168 branch Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants