8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #5071

RealLucy · 2021-08-10T14:50:34Z

Please review this pull request. It hardens the code on ppc and s390 against crashes while collecting stack traces for JFR. Stack frame collection in prims/forte.cpp will benefit from this fix as well as it uses the same platform-specific code.

Testing:
SAP-internal functional and stress testing. Verifying a positive effect is hard because the targeted crashes occur only very rarely. No negative side effects of the fix have been observed.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling

Reviewers

Thomas Stuefe (@tstuefe - Reviewer)
Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5071/head:pull/5071
$ git checkout pull/5071

Update a local copy of the PR:
$ git checkout pull/5071
$ git pull https://git.openjdk.java.net/jdk pull/5071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5071

View PR using the GUI difftool:
$ git pr show -t 5071

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5071.diff

…iling

bridgekeeper · 2021-08-10T14:51:04Z

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-08-10T14:54:14Z

@RealLucy The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-08-10T14:58:40Z

Webrevs

00: Full (69be3a72)

RealLucy · 2021-08-10T19:59:15Z

The failing Pre-submit tests on Windows x64 are unrelated to this fix. Changes for this fix are in platform-specific files only (os_cpu/linux-ppc, os_cpu/linux-s390, cpu/ppc, cpu/s390). They can't impact Windows x64.

RealLucy · 2021-08-10T20:04:42Z

/label add hotspot-jfr

openjdk · 2021-08-10T20:05:09Z

@RealLucy The label jfr is not a valid label. These labels are valid:

serviceability
hotspot
sound
hotspot-compiler
ide-support
kulla
i18n
shenandoah
jdk
javadoc
security
2d
swing
hotspot-runtime
jmx
nio
build
beans
core-libs
compiler
net
hotspot-gc
hotspot-jfr
awt

RealLucy · 2021-08-10T20:08:31Z

/label add hotspot-jfr

openjdk · 2021-08-10T20:09:01Z

@RealLucy
The hotspot-jfr label was successfully added.

tstuefe

LGTM. Minor comment nits.

tstuefe · 2021-08-17T03:37:25Z

src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp

+      //  - ret_frame is constructed with _fp == NULL (for whatever reason)
+      //  - ijava_state_unchecked() calculates it's result as
+      //      istate = fp() - z_ijava_state_size() = NULL - 0x68 DEBUG_ONLY(-8)
+      //  - istate->method dereferences memory at offset 8 from istate


I think a reference to the JBS issue would suffice as a comment here.

Years ago, I was told that direct references to JBS bugs in the code are strongly discouraged. On the other hand, I regard it as very important to have a detailed description available. So what to do? I need a second review anyway. Maybe she has a third opinion on that.

By the way: Thanks a lot for the review!!!

openjdk · 2021-08-17T03:39:33Z

@RealLucy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling

Reviewed-by: stuefe, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 170 new commits pushed to the master branch:

9ede41b: 8229031: Exporting CLASSPATH from shell can result in build failures
16e8305: 8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize
f55d5ab: 8272838: Move CriticalJNI tests out of tier1
a9188f2: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
1fb798d: 8272915: (doc) package-info typo in extLink
5116784: 8273091: Doc of [Strict]Math.floorDiv(long,int) erroneously documents int in @return tag
e66c8af: 8272866: java.util.random package summary contains incorrect mixing function in table
d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
a033aa5: 8273072: Avoid using += in configure
... and 160 more: https://git.openjdk.java.net/jdk/compare/35b399aca810db63371ff65046f047ef0b955161...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

RealLucy · 2021-08-30T12:29:16Z

Thank you, Matthias, for reviewing and approving this fix. Will integrate now.

RealLucy · 2021-08-30T12:29:31Z

/integrate

openjdk · 2021-08-30T12:31:14Z

Going to push as commit 276b07b.
Since your change was applied there have been 171 commits pushed to the master branch:

bb7aa1c: 8272161: Make evacuation failure data structures local to collection
9ede41b: 8229031: Exporting CLASSPATH from shell can result in build failures
16e8305: 8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize
f55d5ab: 8272838: Move CriticalJNI tests out of tier1
a9188f2: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
1fb798d: 8272915: (doc) package-info typo in extLink
5116784: 8273091: Doc of [Strict]Math.floorDiv(long,int) erroneously documents int in @return tag
e66c8af: 8272866: java.util.random package summary contains incorrect mixing function in table
d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
... and 161 more: https://git.openjdk.java.net/jdk/compare/35b399aca810db63371ff65046f047ef0b955161...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-08-30T12:31:26Z

@RealLucy Pushed as commit 276b07b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

RealLucy · 2021-09-10T10:29:13Z

/backport jdk17u

openjdk · 2021-09-10T10:30:29Z

@RealLucy Unknown command backport - for a list of valid commands use /help.

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_prof…

69be3a7

…iling

openjdk bot added the rfr Pull request is ready for review label Aug 10, 2021

openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 10, 2021

openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 10, 2021

tstuefe approved these changes Aug 17, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2021

MBaesken approved these changes Aug 30, 2021

View reviewed changes

openjdk bot closed this Aug 30, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2021

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #5071

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #5071

RealLucy commented Aug 10, 2021 •

edited by openjdk bot

bridgekeeper bot commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

mlbridge bot commented Aug 10, 2021

RealLucy commented Aug 10, 2021

RealLucy commented Aug 10, 2021 •

edited

openjdk bot commented Aug 10, 2021

RealLucy commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

tstuefe left a comment

tstuefe Aug 17, 2021

RealLucy Aug 17, 2021

RealLucy Aug 17, 2021

openjdk bot commented Aug 17, 2021 •

edited

RealLucy commented Aug 30, 2021

RealLucy commented Aug 30, 2021

openjdk bot commented Aug 30, 2021

openjdk bot commented Aug 30, 2021

RealLucy commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #5071

8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #5071

Conversation

RealLucy commented Aug 10, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

mlbridge bot commented Aug 10, 2021

Webrevs

RealLucy commented Aug 10, 2021

RealLucy commented Aug 10, 2021 • edited

openjdk bot commented Aug 10, 2021

RealLucy commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

tstuefe left a comment

Choose a reason for hiding this comment

tstuefe Aug 17, 2021

Choose a reason for hiding this comment

RealLucy Aug 17, 2021

Choose a reason for hiding this comment

RealLucy Aug 17, 2021

Choose a reason for hiding this comment

openjdk bot commented Aug 17, 2021 • edited

RealLucy commented Aug 30, 2021

RealLucy commented Aug 30, 2021

openjdk bot commented Aug 30, 2021

openjdk bot commented Aug 30, 2021

RealLucy commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

RealLucy commented Aug 10, 2021 •

edited by openjdk bot

RealLucy commented Aug 10, 2021 •

edited

openjdk bot commented Aug 17, 2021 •

edited