8272291: mark hotspot runtime/logging tests which ignore external VM flags #5075

iignatev · 2021-08-10T20:03:52Z

Hi all,

could you please review the patch that adds @requires vm.flagless to 23 hotspot runtime/logging tests that ignore external VM flags?

Thanks,
-- Igor

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8272291: mark hotspot runtime/logging tests which ignore external VM flags

Reviewers

Mikhailo Seledtsov (@mseledts - Committer) ⚠️ Review applies to 5a5357c
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5075/head:pull/5075
$ git checkout pull/5075

Update a local copy of the PR:
$ git checkout pull/5075
$ git pull https://git.openjdk.java.net/jdk pull/5075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5075

View PR using the GUI difftool:
$ git pr show -t 5075

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5075.diff

bridgekeeper · 2021-08-10T20:04:10Z

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-08-10T20:07:23Z

@iignatev The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-08-10T20:11:42Z

Webrevs

01: Full - Incremental (09895868)
00: Full (5a5357ce)

mseledts

Looks good.

iignatev · 2021-08-12T23:10:22Z

Thanks, Misha.

can I also get a Review from a Reviewer?

-- Igor

iignatev · 2021-08-16T21:40:25Z

ping?

dholmes-ora

Hi Igor,

There are a couple of changes to existing @requires that I don't agree with. Otherwise all seems okay.

Thanks,
David

dholmes-ora · 2021-08-17T02:01:01Z

test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java

@@ -25,7 +25,7 @@
 /*
 * @test ClassLoadUnloadTest
 * @bug 8142506
- * @requires vm.opt.final.ClassUnloading


The new requirement is weaker than the old. If ClassUnloading were not enabled by default then this test would now run when it should not.

nice catch, I guess I assumed that the test makes sure its child JVMs are run in the correct setting (as CompressedOopsTest.java does). I'll update the test to pass -XX:+ClassUnloading in ClassLoadUnloadTest::exec.

They are not exactly equivalent conditions, but when combined with vm.flagless this change seems okay.

dholmes-ora · 2021-08-17T02:01:01Z

test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java

- * @requires vm.bits == 64 & vm.opt.final.UseCompressedOops == true
+ * @requires vm.bits == 64
+ * @requires vm.flagless


Similar comment here, you have weakened the condition that enables the test.

this test explicitly passes -XX:+UseCompressedOops to a child JVM, so the condition hasn't been weakened, if anything this change increases the coverage for JVMs where UseCompressedOops isn't true by default as now the test will be included in out-of-box runs.

Okay. Thinking more about this case I think the old condition was to stop this test from being run when compressed oops was actually disabled, because it was going to enable them anyway. But now vm.flagless takes care of that case.

dholmes-ora

Comments below but good to go.

Thanks,
David

dholmes-ora · 2021-08-17T04:59:32Z

test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java

@@ -25,7 +25,7 @@
 /*
 * @test ClassLoadUnloadTest
 * @bug 8142506
- * @requires vm.opt.final.ClassUnloading


They are not exactly equivalent conditions, but when combined with vm.flagless this change seems okay.

dholmes-ora · 2021-08-17T04:59:32Z

test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java

- * @requires vm.bits == 64 & vm.opt.final.UseCompressedOops == true
+ * @requires vm.bits == 64
+ * @requires vm.flagless


Okay. Thinking more about this case I think the old condition was to stop this test from being run when compressed oops was actually disabled, because it was going to enable them anyway. But now vm.flagless takes care of that case.

openjdk · 2021-08-17T05:00:53Z

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272291: mark hotspot runtime/logging tests which ignore external VM flags

Reviewed-by: mseledtsov, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

989f39f: 8272552: mark hotspot runtime/cds tests which ignore external VM flags
ee8bf10: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
3fb1927: 8271227: Missing {@code } in com.sun.source.*
a5ad772: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
ae45592: 8272374: doclint should report missing "body" comments
b2c272d: 8272305: several hotspot runtime/modules don't check exit codes
8268825: 8272297: FileInputStream should override transferTo() for better performance
3677734: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail
0a03481: 8272231: G1: Refactor G1CardSet::get_card_set to return G1CardSetHashTableValue*
83d0e12: 8267833: Improve G1CardSetInlinePtr::add()
... and 58 more: https://git.openjdk.java.net/jdk/compare/abdc1074dcefda9012bb4d84c9f34a2dca5ea560...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

iignatev · 2021-08-17T19:35:13Z

David, thank you for the review.

/integrate

openjdk · 2021-08-17T19:36:50Z

Going to push as commit 05d64da.
Since your change was applied there have been 78 commits pushed to the master branch:

a68b5b9: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
a199ebc: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182
1cbf41a: 8225083: Remove Google certificate that is expiring in December 2021
cf64c3e: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails
2ed7b70: 8272521: Remove unused PSPromotionManager::_claimed_stack_breadth
2aaf795: 8272520: Inline GenericTaskQueue::initialize() to the constructor
ed57cf1: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
0e3fde6: 8264274: Block tags in overview.html are ignored
c5c84b8: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java
df1427b: 8272446: C1: Raw version of UnsafeGet generates load barriers
... and 68 more: https://git.openjdk.java.net/jdk/compare/abdc1074dcefda9012bb4d84c9f34a2dca5ea560...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-08-17T19:37:03Z

@iignatev Pushed as commit 05d64da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

iignatev added 2 commits Aug 10, 2021

8272291

2c66a41

copyright year

5a5357c

openjdk bot changed the title ~~8272291~~ 8272291: mark hotspot runtime/logging tests which ignore external VM flags Aug 10, 2021

openjdk bot added the rfr Pull request is ready for review label Aug 10, 2021

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 10, 2021

mseledts approved these changes Aug 10, 2021

View changes

dholmes-ora suggested changes Aug 17, 2021

View changes

added -XX:+ClassUnloading in logging/ClassLoadUnloadTest.java

0989586

dholmes-ora approved these changes Aug 17, 2021

View changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2021

openjdk bot closed this Aug 17, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2021

iignatev deleted the 8272291 branch Aug 18, 2021

8272291: mark hotspot runtime/logging tests which ignore external VM flags #5075

8272291: mark hotspot runtime/logging tests which ignore external VM flags #5075

iignatev commented Aug 10, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

mlbridge bot commented Aug 10, 2021 •

edited

mseledts left a comment

iignatev commented Aug 12, 2021

iignatev commented Aug 16, 2021

dholmes-ora left a comment

dholmes-ora Aug 17, 2021

iignatev Aug 17, 2021

dholmes-ora Aug 17, 2021

dholmes-ora Aug 17, 2021

iignatev Aug 17, 2021

dholmes-ora Aug 17, 2021

dholmes-ora left a comment

dholmes-ora Aug 17, 2021

dholmes-ora Aug 17, 2021

openjdk bot commented Aug 17, 2021 •

edited

iignatev commented Aug 17, 2021

openjdk bot commented Aug 17, 2021

openjdk bot commented Aug 17, 2021

8272291: mark hotspot runtime/logging tests which ignore external VM flags #5075

8272291: mark hotspot runtime/logging tests which ignore external VM flags #5075

Conversation

iignatev commented Aug 10, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Aug 10, 2021

openjdk bot commented Aug 10, 2021

mlbridge bot commented Aug 10, 2021 • edited

Webrevs

mseledts left a comment

iignatev commented Aug 12, 2021

iignatev commented Aug 16, 2021

dholmes-ora left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Aug 17, 2021 • edited

iignatev commented Aug 17, 2021

openjdk bot commented Aug 17, 2021

openjdk bot commented Aug 17, 2021

iignatev commented Aug 10, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Aug 10, 2021 •

edited

openjdk bot commented Aug 17, 2021 •

edited