Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261455: Automatically generate the CDS archive if necessary #5077

Closed
wants to merge 3 commits into from

Conversation

yminqi
Copy link
Contributor

@yminqi yminqi commented Aug 10, 2021

When shared archive (dynamic archive) failed to map due to damage of the archive file, dump/run jdk version mismatch or non-existence file etc, the new patch will automatically create a new shared archive if -XX:+AutoCreateSharedArchive specified with the name based on SharedArchiveFile.

Tests: tier1,tier2,tier3,tier4

Thanks
Yumin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261455: Automatically generate the CDS archive if necessary

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5077/head:pull/5077
$ git checkout pull/5077

Update a local copy of the PR:
$ git checkout pull/5077
$ git pull https://git.openjdk.java.net/jdk pull/5077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5077

View PR using the GUI difftool:
$ git pr show -t 5077

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5077.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 10, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2021

@yminqi The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 10, 2021
@openjdk openjdk bot added the rfr label Aug 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 10, 2021

Webrevs

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 12, 2021

/csr needed

@openjdk openjdk bot added the csr label Aug 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@dholmes-ora this pull request will not be integrated until the CSR request JDK-8272331 for issue JDK-8261455 has been approved.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2021

@yminqi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Sep 13, 2021

The work will continue after related small bug fixed first.

@openjdk openjdk bot removed the csr label Sep 20, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

@yminqi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Oct 11, 2021

Will submit a new patch since 8273152 integration.

@yminqi yminqi closed this Oct 11, 2021
@yminqi yminqi deleted the jdk-8261455 branch Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime rfr
2 participants