Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272310: AArch64: Add missing changes for shared vector helper methods in m4 files #5081

Closed
wants to merge 1 commit into from

Conversation

@XiaohongGong
Copy link
Contributor

@XiaohongGong XiaohongGong commented Aug 11, 2021

This is a followed-up fixing to [1] which moved several vector helper methods to a shared header. However, the changes in the
aarch64 ad files (aarch64_neon.ad, aarch64_sve.ad) are forgotten to be added into the relative m4 files.

This patch adds the missing changes in the m4 files to make everything right.

[1] https://bugs.openjdk.java.net/browse/JDK-8270519


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272310: AArch64: Add missing changes for shared vector helper methods in m4 files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5081/head:pull/5081
$ git checkout pull/5081

Update a local copy of the PR:
$ git checkout pull/5081
$ git pull https://git.openjdk.java.net/jdk pull/5081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5081

View PR using the GUI difftool:
$ git pr show -t 5081

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5081.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 11, 2021

👋 Welcome back xgong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Aug 11, 2021

Hi, could anyone please help to take a look at this simple PR? Thanks so much!

Loading

@openjdk openjdk bot added the rfr label Aug 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@XiaohongGong The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 11, 2021

Webrevs

Loading

@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Aug 12, 2021

Thanks for the review @martin-g !

Loading

Copy link
Member

@DamonFool DamonFool left a comment

Looks good to me and trivial.
Thanks.

Loading

@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Aug 12, 2021

Thanks for the review @DamonFool !

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@XiaohongGong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272310: AArch64: Add missing changes for shared vector helper methods in m4 files

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • b29fbad: 8267844: Replace Integer/Long.valueOf() with Integer/Long.parse*() where applicable
  • d38b314: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
  • a15b659: 8271732: Regression in StringBuilder.charAt bounds checking
  • ec2fc38: 8272120: Avoid looking for standard encodings in "java." modules
  • bd27bb9: 8272345: macos doesn't check os::set_boot_path() result
  • 44f137f: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/5350b9901c6cebe5d40bbba9a31d1f26285b1cd6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Aug 12, 2021
@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Aug 12, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Aug 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@XiaohongGong
Your change (at version 28a4fb0) is now ready to be sponsored by a Committer.

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 12, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

Going to push as commit 7e14c3c.
Since your change was applied there have been 19 commits pushed to the master branch:

  • b29fbad: 8267844: Replace Integer/Long.valueOf() with Integer/Long.parse*() where applicable
  • d38b314: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
  • a15b659: 8271732: Regression in StringBuilder.charAt bounds checking
  • ec2fc38: 8272120: Avoid looking for standard encodings in "java." modules
  • bd27bb9: 8272345: macos doesn't check os::set_boot_path() result
  • 44f137f: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/5350b9901c6cebe5d40bbba9a31d1f26285b1cd6...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@DamonFool Pushed as commit 7e14c3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@XiaohongGong XiaohongGong deleted the JDK-8272310 branch Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants