Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272318: Improve performance of HeapDumpAllTest #5084

Closed
wants to merge 1 commit into from

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Aug 11, 2021

This change triggers a GC by System.gc() in the test case, so the created heap dump is significantly smaller and the test runs much faster.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5084/head:pull/5084
$ git checkout pull/5084

Update a local copy of the PR:
$ git checkout pull/5084
$ git pull https://git.openjdk.java.net/jdk pull/5084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5084

View PR using the GUI difftool:
$ git pr show -t 5084

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5084.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2021

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2021
@openjdk
Copy link

openjdk bot commented Aug 11, 2021

@schmelter-sap The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 11, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2021

Webrevs

@plummercj
Copy link
Contributor

Is there a reason you don't want this change to also apply to HeapDumpTest?

@mrserb
Copy link
Member

mrserb commented Aug 12, 2021

I also tried to improve this test, it almost always fails because of OOM when tried to parse the heap dump, the solution which works on my system is to mark the test as othervm. Can we do this in this change, or I can create a separate CR.

@schmelter-sap
Copy link
Contributor Author

Is there a reason you don't want this change to also apply to HeapDumpTest?

Since the GC.heap_dump already does a GC it is not really needed. Of course doing the gc in HeapDumpTest is a smaller change, so I'm open for that.

@linzang
Copy link
Contributor

linzang commented Aug 13, 2021

Is there a reason you don't want this change to also apply to HeapDumpTest?

Since the GC.heap_dump already does a GC it is not really needed. Of course doing the gc in HeapDumpTest is a smaller change, so I'm open for that.

I prefer having System.gc() for "-all=true" only, IMO if put it into the HeapDumpTest, there can be 2 gc triggered, one from System.gc() and one from heapdump, which may be not necessary.

One more question, is there necessary to have a test for using argument "-all=false" explicitly? Although it is used by default, maybe we need to test whether jcmd could accept the arguments normally.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Thanks for optimizing!

@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@schmelter-sap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272318: Improve performance of HeapDumpAllTest

Reviewed-by: lucy, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 5189047: 8272558: IR Test Framework README misses some flags
  • ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • 14623cd: 8270835: regression after JDK-8261006
  • fe72197: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/2b05fae15568d5eb91d6d6d32c29f2fda453a8f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ralf,
The fix looks good to me.
Thanks,
Serguei

@schmelter-sap
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2021

Going to push as commit 73da66f.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 5189047: 8272558: IR Test Framework README misses some flags
  • ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • 14623cd: 8270835: regression after JDK-8261006
  • fe72197: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/2b05fae15568d5eb91d6d6d32c29f2fda453a8f5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2021
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@schmelter-sap Pushed as commit 73da66f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
6 participants