Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272330: C2: Cleanup profile counter scaling #5087

Closed
wants to merge 1 commit into from

Conversation

veresov
Copy link
Contributor

@veresov veresov commented Aug 11, 2021

Confusing computation during profile counter scaling was left as vestige of the old compilation policy. Clean it up.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5087/head:pull/5087
$ git checkout pull/5087

Update a local copy of the PR:
$ git checkout pull/5087
$ git pull https://git.openjdk.java.net/jdk pull/5087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5087

View PR using the GUI difftool:
$ git pr show -t 5087

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5087.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 11, 2021

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@veresov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Aug 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 11, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272330: C2: Cleanup profile counter scaling

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
  • cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
  • 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • abebbe2: 8267186: Add string deduplication support to ZGC
  • 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
  • 3215dbc: 8271928: ErroneousTree with start position -1
  • adba09b: 8272146: Disable Fibonacci test on memory constrained systems
  • 846cc88: 8272138: ZGC: Adopt relaxed ordering for self-healing
  • 5350b99: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 1489352: 8271718: Crash when during color transformation the color profile is replaced
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/b62e7420450dad5a807a5afa0f65f6632b344e29...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 11, 2021
@veresov
Copy link
Contributor Author

@veresov veresov commented Aug 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

Going to push as commit 9faab40.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
  • 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
  • cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
  • 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • abebbe2: 8267186: Add string deduplication support to ZGC
  • 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
  • 3215dbc: 8271928: ErroneousTree with start position -1
  • adba09b: 8272146: Disable Fibonacci test on memory constrained systems
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/b62e7420450dad5a807a5afa0f65f6632b344e29...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 11, 2021

@veresov Pushed as commit 9faab40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
2 participants