8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes

[iignatev]

Hi all,

could you please review this small patch that adds exit code checks to runtime/cds/appcds/MoveJDKTest.java test?

testing: runtime/cds/appcds/MoveJDKTest.java on linux-x64-{product,fastdebug}

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes

Reviewers

• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5089/head:pull/5089
$ git checkout pull/5089

Update a local copy of the PR:
$ git checkout pull/5089
$ git pull https://git.openjdk.java.net/jdk pull/5089/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5089

View PR using the GUI difftool:
$ git pr show -t 5089

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5089.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6863d91b)

[iklam]

LGTM.

[iignatev]

Thanks, Ioi.

/integrate

[openjdk]

@iignatev This PR has not yet been marked as ready for integration.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
• ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
• 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
• cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
• 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
• abebbe2: 8267186: Add string deduplication support to ZGC
• 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
• 3215dbc: 8271928: ErroneousTree with start position -1
• adba09b: 8272146: Disable Fibonacci test on memory constrained systems
• 846cc88: 8272138: ZGC: Adopt relaxed ordering for self-healing
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/abdc1074dcefda9012bb4d84c9f34a2dca5ea560...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

/integrate

[openjdk]

Going to push as commit 75a0642.
Since your change was applied there have been 25 commits pushed to the master branch:

• 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
• ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
• 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
• cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
• 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
• abebbe2: 8267186: Add string deduplication support to ZGC
• 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
• 3215dbc: 8271928: ErroneousTree with start position -1
• adba09b: 8272146: Disable Fibonacci test on memory constrained systems
• 846cc88: 8272138: ZGC: Adopt relaxed ordering for self-healing
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/abdc1074dcefda9012bb4d84c9f34a2dca5ea560...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 75a0642.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.