Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8234393: [macos] printing ignores printer tray #509

Closed
wants to merge 2 commits into from

Conversation

vipinmenon
Copy link
Contributor

@vipinmenon vipinmenon commented Oct 5, 2020

Issue

https://bugs.openjdk.java.net/browse/JDK-8234393

Problem

On a multi tray printer, irrespective of what tray is set, Java always prints from the last tray which is the default.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/509/head:pull/509
$ git checkout pull/509

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 5, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2020

Hi @vipinmenon, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user vipinmenon" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@vipinmenon The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org labels Oct 5, 2020
@vipinmenon
Copy link
Contributor Author

vipinmenon commented Oct 6, 2020

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 6, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2020

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 7, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2020

Webrevs

@prrace
Copy link
Contributor

prrace commented Oct 7, 2020

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@prrace
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

prrace
prrace approved these changes Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@vipinmenon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8234393: [macos] printing ignores printer tray

Reviewed-by: psadhukhan, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 191 new commits pushed to the master branch:

  • 3f9c8a3: 8254966: Remove unused code from Matcher
  • 21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
  • 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
  • 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
  • 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
  • 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
  • 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
  • 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
  • 0a75b37: 8254776: Remove unimplemented LowMemoryDetector::check_memory_usage
  • b65dcfa: 8197981: Missing return statement in __sync_val_compare_and_swap_8
  • ... and 181 more: https://git.openjdk.java.net/jdk/compare/1e8e543b264bb985bfee535fedc9ffe7db5ad482...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
@vipinmenon
Copy link
Contributor Author

vipinmenon commented Oct 20, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 20, 2020
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@vipinmenon
Your change (at version 9e876d2) is now ready to be sponsored by a Committer.

@prsadhuk
Copy link
Contributor

prsadhuk commented Oct 20, 2020

/sponsor

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored labels Oct 20, 2020
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2020
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@prsadhuk @vipinmenon Since your change was applied there have been 191 commits pushed to the master branch:

  • 3f9c8a3: 8254966: Remove unused code from Matcher
  • 21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
  • 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
  • 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
  • 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
  • 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
  • 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
  • 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
  • 0a75b37: 8254776: Remove unimplemented LowMemoryDetector::check_memory_usage
  • b65dcfa: 8197981: Missing return statement in __sync_val_compare_and_swap_8
  • ... and 181 more: https://git.openjdk.java.net/jdk/compare/1e8e543b264bb985bfee535fedc9ffe7db5ad482...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3ee0380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants