Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 #5091

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Aug 11, 2021

Please review this simple build fix to correct the typo done in JDK-8255790. After the patch correct external library is added to the libfontmanager.so link command when building with --with-harfbuzz=system.

Thoughts?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5091/head:pull/5091
$ git checkout pull/5091

Update a local copy of the PR:
$ git checkout pull/5091
$ git pull https://git.openjdk.java.net/jdk pull/5091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5091

View PR using the GUI difftool:
$ git pr show -t 5091

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5091.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2021
@openjdk
Copy link

openjdk bot commented Aug 11, 2021

@jerboaa The following labels will be automatically applied to this pull request:

  • 2d
  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org build build-dev@openjdk.org labels Aug 11, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2021

Webrevs

prrace
prrace approved these changes Aug 11, 2021
@openjdk
Copy link

openjdk bot commented Aug 11, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a15b659: 8271732: Regression in StringBuilder.charAt bounds checking
  • ec2fc38: 8272120: Avoid looking for standard encodings in "java." modules
  • bd27bb9: 8272345: macos doesn't check os::set_boot_path() result
  • 44f137f: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 11, 2021
@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 12, 2021

Thanks for the review @prrace!

@jerboaa
Copy link
Contributor Author

jerboaa commented Aug 12, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2021

Going to push as commit d38b314.
Since your change was applied there have been 9 commits pushed to the master branch:

  • a15b659: 8271732: Regression in StringBuilder.charAt bounds checking
  • ec2fc38: 8272120: Avoid looking for standard encodings in "java." modules
  • bd27bb9: 8272345: macos doesn't check os::set_boot_path() result
  • 44f137f: 8271170: Add unit test for what jpackage app launcher puts in the environment
  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2021
@openjdk
Copy link

openjdk bot commented Aug 12, 2021

@jerboaa Pushed as commit d38b314.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org build build-dev@openjdk.org integrated Pull request has been integrated
2 participants