Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272327: Shenandoah: Avoid enqueuing duplicate string candidates #5096

wants to merge 1 commit into from


Copy link

@zhengyu123 zhengyu123 commented Aug 12, 2021

Now, there is a new API java_lang_String::test_and_set_deduplication_requested() that can help to identify if a string candidate has been enqueued, so that we can avoid enqueuing duplicate entries.


  • hotspot_gc_shenandoah


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8272327: Shenandoah: Avoid enqueuing duplicate string candidates



Using git

Checkout this PR locally:
$ git fetch pull/5096/head:pull/5096
$ git checkout pull/5096

Update a local copy of the PR:
$ git checkout pull/5096
$ git pull pull/5096/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5096

View PR using the GUI difftool:
$ git pr show -t 5096

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Aug 12, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.


@openjdk openjdk bot added the rfr label Aug 12, 2021
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.


Copy link

@mlbridge mlbridge bot commented Aug 12, 2021



Copy link

@rkennke rkennke left a comment

Looks good to me, thanks!


Copy link

@openjdk openjdk bot commented Aug 16, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8272327: Shenandoah: Avoid enqueuing duplicate string candidates

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 5db36ce: 8272158: SoftReference related bugs under memory pressure
  • 7a5b37b: 8272439: G1: add documentation to G1CardSetInlinePtr
  • 0209d9f: 8272461: G1: remove empty declaration of cleanup_after_scan_heap_roots
  • 36e2dda: 8272348: Update CDS tests in anticipation of JDK-8270489
  • 3f38a50: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 6a5241c: 8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/ on macos
  • 17b9350: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
  • 87d2761: 8271883: Math CopySign optimization for x86
  • 6b8b160: 8272396: mismatching debug output streams
  • 0af645a: 8205138: Remove Applet references from Font2DTest
  • ... and 25 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.


@openjdk openjdk bot added the ready label Aug 16, 2021
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Aug 17, 2021



Copy link

@openjdk openjdk bot commented Aug 17, 2021

Going to push as commit ee8bf10.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 3fb1927: 8271227: Missing {@code } in com.sun.source.*
  • a5ad772: 8272342: [TEST_BUG] java/awt/print/PrinterJob/ catches all exceptions
  • ae45592: 8272374: doclint should report missing "body" comments
  • b2c272d: 8272305: several hotspot runtime/modules don't check exit codes
  • 8268825: 8272297: FileInputStream should override transferTo() for better performance
  • 3677734: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail
  • 0a03481: 8272231: G1: Refactor G1CardSet::get_card_set to return G1CardSetHashTableValue*
  • 83d0e12: 8267833: Improve G1CardSetInlinePtr::add()
  • 69cc588: 8272235: G1: update outdated code root fixup
  • 5db36ce: 8272158: SoftReference related bugs under memory pressure
  • ... and 34 more:

Your commit was automatically rebased without conflicts.


@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 17, 2021
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@zhengyu123 Pushed as commit ee8bf10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants