Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders #5100

Closed
wants to merge 4 commits into from

Conversation

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Aug 12, 2021

This is a doc-only fix that improves the wording of the API doc of getRequestHeaders(). The other changes are trivial cleanup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5100/head:pull/5100
$ git checkout pull/5100

Update a local copy of the PR:
$ git checkout pull/5100
$ git pull https://git.openjdk.java.net/jdk pull/5100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5100

View PR using the GUI difftool:
$ git pr show -t 5100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5100.diff

@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Aug 12, 2021

/csr needed

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 12, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@FrauBoes has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@FrauBoes please create a CSR request for issue JDK-8272334. This pull request cannot be integrated until the CSR request is approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the net label Aug 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 12, 2021

Webrevs

Loading

dfuch
dfuch approved these changes Aug 12, 2021
@dfuch
Copy link
Member

@dfuch dfuch commented Aug 12, 2021

Please have Michael review the changes too before pushing

Loading

@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Aug 17, 2021

Loading

dfuch
dfuch approved these changes Aug 17, 2021
@openjdk openjdk bot removed the csr label Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

Reviewed-by: dfuchs, michaelm, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 5189047: 8272558: IR Test Framework README misses some flags
  • ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • 14623cd: 8270835: regression after JDK-8261006
  • fe72197: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • ... and 56 more: https://git.openjdk.java.net/jdk/compare/619422764d55875c1b9687ae7e9ce4dc99b71bf9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 18, 2021
@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Aug 19, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

Going to push as commit 1c80f07.
Since your change was applied there have been 68 commits pushed to the master branch:

  • 6d3d479: 8272667: substandard error messages from the docs build
  • 73da66f: 8272318: Improve performance of HeapDumpAllTest
  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 5189047: 8272558: IR Test Framework README misses some flags
  • ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/619422764d55875c1b9687ae7e9ce4dc99b71bf9...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@FrauBoes Pushed as commit 1c80f07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@FrauBoes FrauBoes deleted the 8272334 branch Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants