8272417: ZGC: fastdebug build crashes when printing ClassLoaderData

[tbzhang]

Following test fails on fastdebug build with the options: "-XX:+UseZGC -XX:+VerifyAfterGC -Xlog:gc*=trace". It crashes on the unknown claim value of the ClassLoaderData

public class A {
public static void main(String... args) {
System.gc();
}
}

The unknown claim value of the ClassLoaderData is "ClassLoaderData::_claim_other | ClassLoaderData::_claim_strong" which is introduced by the ZVerifyOopClosure. This patch clears the CLD's claimed marks after the ZGC verification

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272417: ZGC: fastdebug build crashes when printing ClassLoaderData

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Per Liden (@pliden - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5107/head:pull/5107
$ git checkout pull/5107

Update a local copy of the PR:
$ git checkout pull/5107
$ git pull https://git.openjdk.java.net/jdk pull/5107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5107

View PR using the GUI difftool:
$ git pr show -t 5107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5107.diff

[bridgekeeper]

Hi @tbzhang, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tbzhang" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[tbzhang]

/covered

[openjdk]

@tbzhang The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[robilad]

Hi, please contact me at Dalibor.Topic@oracle.com so that I can mark your account as verified.

[tbzhang]

Hi, please contact me at Dalibor.Topic@oracle.com so that I can mark your account as verified.

Thank you!

[mlbridge]

Webrevs

• 01: Full - Incremental (c7912154)
• 00: Full (bcf609ef)

[stefank]

I mentioned in the bug report that this is not enough to correctly fix this bug. Could you fix the printing code instead?

[tbzhang]

I mentioned in the bug report that this is not enough to correctly fix this bug. Could you fix the printing code instead?

Yes, Thanks for your advice!

[stefank]

Looks good. Thanks.

[openjdk]

@tbzhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272417: ZGC: fastdebug build crashes when printing ClassLoaderData

Reviewed-by: stefank, pliden

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
• f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• 1ea437a: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• 86add21: 8223923: C2: Missing interference with mismatched unsafe accesses
• c701f6e: 8272739: Misformatted error message in EventHandlerCreator
• fb1dfc6: 8267185: Add string deduplication support to ParallelGC
• ... and 76 more: https://git.openjdk.java.net/jdk/compare/ec2fc384e50668b667335f973ffeb5a19bbcfb9b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @pliden) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[pliden]

Looks good.

[tbzhang]

/integrate

[openjdk]

@tbzhang
Your change (at version c791215) is now ready to be sponsored by a Committer.

[stefank]

/sponsor

[openjdk]

Going to push as commit 741f58c.
Since your change was applied there have been 86 commits pushed to the master branch:

• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
• f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• 1ea437a: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• 86add21: 8223923: C2: Missing interference with mismatched unsafe accesses
• c701f6e: 8272739: Misformatted error message in EventHandlerCreator
• fb1dfc6: 8267185: Add string deduplication support to ParallelGC
• ... and 76 more: https://git.openjdk.java.net/jdk/compare/ec2fc384e50668b667335f973ffeb5a19bbcfb9b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank @tbzhang Pushed as commit 741f58c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.