Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos #5119

Closed
wants to merge 1 commit into from
Closed

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Aug 15, 2021

This will fail regularly so problem list it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5119/head:pull/5119
$ git checkout pull/5119

Update a local copy of the PR:
$ git checkout pull/5119
$ git pull https://git.openjdk.java.net/jdk pull/5119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5119

View PR using the GUI difftool:
$ git pr show -t 5119

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5119.diff

@prrace
Copy link
Contributor Author

@prrace prrace commented Aug 15, 2021

/label 2d,swing

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 15, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

@prrace
The 2d label was successfully added.

The swing label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 15, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Aug 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

Going to push as commit 6a5241c.

@openjdk openjdk bot closed this Aug 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

@prrace Pushed as commit 6a5241c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants