New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8067127: Tags cleanup #513
Conversation
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
Webrevs
|
From the perspective of the Standard Doclet this change looks good. I have to note, however, that there are minor losses in markup, e.g. unused italic highlighting such as |
Thanks. I didn't think that the loss of italics was significant where this change was applied. |
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
…/bplb/jdk into JDK-8067127-java-io-tags-cleanup
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes LGTM!
best regards,
-- daniel
/integrate |
@bplb Since your change was applied there have been 31 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit db3053d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change to update some javadoc tags in the java.io package. The changes are to replace some occurrences of
some_code
with {@code some_code}. Not all such constructs were replaced as being infeasible, e.g., tag contains an entity such as*/
(DataOutput, Serial), or multiple {@code} tags would be needed or the result would be ugly (File). It is unclear whether some of the changes which remove the non-breaking space entity ( ) are desirable.Thanks,
Brian
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/513/head:pull/513
$ git checkout pull/513