Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication #5130

Closed
wants to merge 1 commit into from

Conversation

@bplb
Copy link
Member

@bplb bplb commented Aug 16, 2021

Please consider this change which would modify a conditional a + b > c where the left side variables are ints and the right side is (long)Integer.MAX_VALUE + 1. The change is to cast the left side variables to longs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5130/head:pull/5130
$ git checkout pull/5130

Update a local copy of the PR:
$ git checkout pull/5130
$ git pull https://git.openjdk.java.net/jdk pull/5130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5130

View PR using the GUI difftool:
$ git pr show -t 5130

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5130.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 16, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 16, 2021

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Aug 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 16, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

  • d732c30: 8272863: Replace usages of Collections.sort with List.sort call in public java modules
  • fe7d708: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
  • c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
  • e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
  • b94fd32: 8272859: Javadoc external links should only have feature version number in URL
  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/b2c272d4e21eb4aeb6c8e1c0be0d08943dc36db8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 26, 2021
@bplb
Copy link
Member Author

@bplb bplb commented Aug 27, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

Going to push as commit d1aeca1.
Since your change was applied there have been 107 commits pushed to the master branch:

  • dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • a033aa5: 8273072: Avoid using += in configure
  • b92214a: 8272480: Remove Mutex::access rank
  • 596b075: 8258465: Headless build fails due to missing X11 headers on linux
  • a49a0c5: 8273062: Generation::refs_discovery_is_xxx functions are unused
  • ebd62bc: 8272846: Move some runtime/Metaspace/elastic/ tests out of tier1
  • 46684a4: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
  • c925c7f: 8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array
  • 76baace: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
  • b16a04e: 8271186: Add UL option to replace newline char
  • ... and 97 more: https://git.openjdk.java.net/jdk/compare/b2c272d4e21eb4aeb6c8e1c0be0d08943dc36db8...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@bplb Pushed as commit d1aeca1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@bplb bplb deleted the BigInteger-overflow-8272541 branch Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants