Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225083: Remove Google certificate that is expiring in December 2021 #5137

Closed
wants to merge 1 commit into from
Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Aug 17, 2021

Removed the expiring root certificate.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225083: Remove Google certificate that is expiring in December 2021

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5137/head:pull/5137
$ git checkout pull/5137

Update a local copy of the PR:
$ git checkout pull/5137
$ git pull https://git.openjdk.java.net/jdk pull/5137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5137

View PR using the GUI difftool:
$ git pr show -t 5137

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5137.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2021
@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@rhalade The following labels will be automatically applied to this pull request:

  • build
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Aug 17, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225083: Remove Google certificate that is expiring in December 2021

Reviewed-by: xuelei, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ed57cf1: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 0e3fde6: 8264274: Block tags in overview.html are ignored
  • c5c84b8: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java
  • df1427b: 8272446: C1: Raw version of UnsafeGet generates load barriers
  • 989f39f: 8272552: mark hotspot runtime/cds tests which ignore external VM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2021
@rhalade
Copy link
Member Author

rhalade commented Aug 17, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

Going to push as commit 1cbf41a.
Since your change was applied there have been 8 commits pushed to the master branch:

  • cf64c3e: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails
  • 2ed7b70: 8272521: Remove unused PSPromotionManager::_claimed_stack_breadth
  • 2aaf795: 8272520: Inline GenericTaskQueue::initialize() to the constructor
  • ed57cf1: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 0e3fde6: 8264274: Block tags in overview.html are ignored
  • c5c84b8: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java
  • df1427b: 8272446: C1: Raw version of UnsafeGet generates load barriers
  • 989f39f: 8272552: mark hotspot runtime/cds tests which ignore external VM flags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2021
@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@rhalade Pushed as commit 1cbf41a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8225083 branch August 17, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
3 participants