New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 #5147
Conversation
…amsTest.java" This reverts commit 54ed7a8.
…cs12/ParamsTest.java
…cs12/ParamsTest.java
…cs12/ParamsTest.java
…cs12/ParamsTest.java
…cs12/ParamsTest.java
|
@akolarkunnu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@akolarkunnu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
Going to push as commit a199ebc.
Your commit was automatically rebased without conflicts. |
@akolarkunnu Pushed as commit a199ebc. |
MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package and it has dependency with some other library files jdk.test.lib.process.ProcessTools & jdk.test.lib.Platform. These libraries are not there in MultipleLogins's class path and this test fails with compilation error.
So as a fix moving OpensslArtifactFetcher.java to the package jdk.test.lib.security.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5147/head:pull/5147
$ git checkout pull/5147
Update a local copy of the PR:
$ git checkout pull/5147
$ git pull https://git.openjdk.java.net/jdk pull/5147/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5147
View PR using the GUI difftool:
$ git pr show -t 5147
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5147.diff