Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 #5147

Closed
wants to merge 12 commits into from
Closed

8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 #5147

wants to merge 12 commits into from

Conversation

akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Aug 17, 2021

MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package and it has dependency with some other library files jdk.test.lib.process.ProcessTools & jdk.test.lib.Platform. These libraries are not there in MultipleLogins's class path and this test fails with compilation error.

So as a fix moving OpensslArtifactFetcher.java to the package jdk.test.lib.security.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5147/head:pull/5147
$ git checkout pull/5147

Update a local copy of the PR:
$ git checkout pull/5147
$ git pull https://git.openjdk.java.net/jdk pull/5147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5147

View PR using the GUI difftool:
$ git pr show -t 5147

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5147.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2021

👋 Welcome back akolarkunnu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@akolarkunnu The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Aug 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@akolarkunnu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1cbf41a: 8225083: Remove Google certificate that is expiring in December 2021
  • cf64c3e: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 17, 2021
@akolarkunnu
Copy link
Contributor Author

@akolarkunnu akolarkunnu commented Aug 17, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

Going to push as commit a199ebc.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1cbf41a: 8225083: Remove Google certificate that is expiring in December 2021
  • cf64c3e: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@akolarkunnu Pushed as commit a199ebc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants