8272576: G1: Use more accurate integer type for collection set length

[albertnetymk]

Simple change of using smaller integer type, size_t to uint. Also moved the bound-check assertion before array access.

Test: hotspot_gc

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272576: G1: Use more accurate integer type for collection set length

Reviewers

• Ivan Walulya (@walulyai - Committer)
• Stefan Johansson (@kstefanj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5148/head:pull/5148
$ git checkout pull/5148

Update a local copy of the PR:
$ git checkout pull/5148
$ git pull https://git.openjdk.java.net/jdk pull/5148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5148

View PR using the GUI difftool:
$ git pr show -t 5148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5148.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d2ba95e0)

[kstefanj]

Looks good.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272576: G1: Use more accurate integer type for collection set length

Reviewed-by: iwalulya, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 30b0f82: 8272626: Avoid C-style array declarations in java.*
• e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
• 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
• 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
• 5189047: 8272558: IR Test Framework README misses some flags
• ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
• 14623cd: 8270835: regression after JDK-8261006
• fe72197: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
• 05d64da: 8272291: mark hotspot runtime/logging tests which ignore external VM flags
• a68b5b9: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/2ed7b709a197f009632580b17e3b1df34c1ffeb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit ab41812.
Since your change was applied there have been 19 commits pushed to the master branch:

• 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
• 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
• 6d3d479: 8272667: substandard error messages from the docs build
• 73da66f: 8272318: Improve performance of HeapDumpAllTest
• 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
• 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
• 30b0f82: 8272626: Avoid C-style array declarations in java.*
• e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
• 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
• 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
• ... and 9 more: https://git.openjdk.java.net/jdk/compare/2ed7b709a197f009632580b17e3b1df34c1ffeb7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit ab41812.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.