Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254046: Remove double semicolon introduced by JDK-8235521 #515

Closed
wants to merge 1 commit into from

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 5, 2020

Please review this very minor fix to remove a double semicolon introduced by JDK-8235521 in src/java.desktop/share/classes/sun/awt/AWTAccessor.java. It causes an error in my Eclipse IDE.

71d646a#diff-1b28189652c11b47b155b5a20a49fe8bR44


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254046: Remove double semicolon introduced by JDK-8235521

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/515/head:pull/515
$ git checkout pull/515

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2020

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@RealCLanger The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2020

Webrevs

mrserb
mrserb approved these changes Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8254046: Remove double semicolon introduced by JDK-8235521

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 6, 2020

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@RealCLanger Since your change was applied there has been 1 commit pushed to the master branch:

  • 5d84e95: 8204256: improve jlink error message to report unsupported class file format

Your commit was automatically rebased without conflicts.

Pushed as commit 6e61861.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JDK-8254046 branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants