8273435: Remove redundant zero-length check in ClassDesc.of

[turbanoff]

After JDK-8215510 (eed3a53) this condition is always false. Empty package name is handled separately.
Found by IntelliJ inspection.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273435: Remove redundant zero-length check in ClassDesc.of

Reviewers

• @stsypanov (no known github.com user name / role)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5157/head:pull/5157
$ git checkout pull/5157

Update a local copy of the PR:
$ git checkout pull/5157
$ git pull https://git.openjdk.java.net/jdk pull/5157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5157

View PR using the GUI difftool:
$ git pr show -t 5157

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5157.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[stsypanov]

Hi @turbanoff the change looks good and reasonable, I've filed an issue for this: https://bugs.openjdk.java.net/browse/JDK-8273435, so you can integrate now

[mlbridge]

Webrevs

• 00: Full (e1e7a159)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273435: Remove redundant zero-length check in ClassDesc.of

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 177 new commits pushed to the master branch:

• 041ae20: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
• 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
• 70157c7: 8272135: jshell: Method cannot use its overloaded version
• 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
• a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
• 3cd95a2: 8231356: Fix broken ResourceObj::operator new[] in debug builds
• 81c719b: 8273333: Zero should warn about unimplemented -XX:+LogTouchedMethods
• 649c22c: 8270832: Aarch64: Update algorithm annotations for MacroAssembler::fill_words
• eb22181: 8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers
• fc546d6: 8273378: Shenandoah: Remove the remaining uses of os::is_MP
• ... and 167 more: https://git.openjdk.java.net/jdk/compare/79a06df8113ba1da55db5c38fe34608c3507c223...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version e1e7a15) is now ready to be sponsored by a Committer.

[turbanoff]

Can someone sponsor changes, please?

[naotoj]

/sponsor

[openjdk]

Going to push as commit 355356c.
Since your change was applied there have been 481 commits pushed to the master branch:

• 97385d4: 8274405: Suppress warnings on non-serializable non-transient instance fields in javac and javadoc
• 79cebe2: 8274050: Unnecessary Vector usage in javax.crypto
• 97b2874: 8274509: Remove stray * and stylistic . from doc comments
• b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
• edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
• 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
• 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
• aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
• c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
• 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
• ... and 471 more: https://git.openjdk.java.net/jdk/compare/79a06df8113ba1da55db5c38fe34608c3507c223...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj @turbanoff Pushed as commit 355356c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.