Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272626: Avoid C-style array declarations in java.* #5161

Closed
wants to merge 1 commit into from

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Aug 18, 2021

C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages.

(Copyrights intentionally not updated due the triviality of most changes)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272626: Avoid C-style array declarations in java.*

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5161/head:pull/5161
$ git checkout pull/5161

Update a local copy of the PR:
$ git checkout pull/5161
$ git pull https://git.openjdk.java.net/jdk pull/5161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5161

View PR using the GUI difftool:
$ git pr show -t 5161

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5161.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@cl4es The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@cl4es cl4es changed the title Avoid C-style array declarations in java.* 8272626: Avoid C-style array declarations in java.* Aug 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

dfuch
dfuch approved these changes Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272626: Avoid C-style array declarations in java.*

Reviewed-by: dfuchs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 18, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented Aug 18, 2021

Thanks for reviewing, Daniel and Alan!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

Going to push as commit 30b0f82.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@cl4es Pushed as commit 30b0f82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the array_style branch Aug 18, 2021
@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Aug 18, 2021

34 Minutes from proposed to integrated!
Its hard to argue with the efficiency, but only 1 timezone of developers had a chance to review or even be aware of the change.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Mailing list message from Joe Darcy on i18n-dev:

On 8/18/2021 6:20 AM, Roger Riggs wrote:

On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad <redestad at openjdk.org> wrote:

C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages.

(Copyrights intentionally not updated due the triviality of most changes)
34 Minutes from proposed to integrated!
Its hard to argue with the efficiency, but only 1 timezone of developers had a chance to review or even be aware of the change.

I don't think removing use of this archaic language feature, which
doesn't change semantics, should be in any way controversial and is long
overdue.

-Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants