Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272618: Unnecessary Attr.visitIdent.noOuterThisPath #5163

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Aug 18, 2021

This patch removes an unnecessary variable, which was not removed when -source <= 5 was removed:
https://bugs.openjdk.java.net/browse/JDK-8011044


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272618: Unnecessary Attr.visitIdent.noOuterThisPath

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5163/head:pull/5163
$ git checkout pull/5163

Update a local copy of the PR:
$ git checkout pull/5163
$ git pull https://git.openjdk.java.net/jdk pull/5163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5163

View PR using the GUI difftool:
$ git pr show -t 5163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5163.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Aug 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

lgtm

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272618: Unnecessary Attr.visitIdent.noOuterThisPath

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

  • f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
  • b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
  • 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
  • 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
  • 6d3d479: 8272667: substandard error messages from the docs build
  • ... and 102 more: https://git.openjdk.java.net/jdk/compare/a86ac0d1e3a6f02e587362c767abdf62b308d321...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 18, 2021
@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Sep 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

Going to push as commit e600fe1.
Since your change was applied there have been 218 commits pushed to the master branch:

  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • 9c392d0: 8273197: ProblemList 2 jtools tests due to JDK-8273187
  • 3d657eb: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • e551852: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
  • ... and 208 more: https://git.openjdk.java.net/jdk/compare/a86ac0d1e3a6f02e587362c767abdf62b308d321...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@lahodaj Pushed as commit e600fe1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
3 participants