Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic() #5167

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Aug 18, 2021

The two methods do exactly the same, except one returns a bool, the other a value. The only use of cas_forward_to() can be consolidated to use forward_to_atomic() instead.

Testing:

  • hotspot_gc
  • tier1
  • tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5167/head:pull/5167
$ git checkout pull/5167

Update a local copy of the PR:
$ git checkout pull/5167
$ git pull https://git.openjdk.java.net/jdk pull/5167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5167

View PR using the GUI difftool:
$ git pr show -t 5167

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2021
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@rkennke The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 18, 2021
@rkennke
Copy link
Contributor Author

rkennke commented Aug 18, 2021

/cc hotspot-gc

@mlbridge
Copy link

mlbridge bot commented Aug 18, 2021

Webrevs

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 18, 2021
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@rkennke
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()

Reviewed-by: stefank, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6d3d479: 8272667: substandard error messages from the docs build
  • 73da66f: 8272318: Improve performance of HeapDumpAllTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@rkennke
Copy link
Contributor Author

rkennke commented Aug 19, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

Going to push as commit f4be211.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
  • 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
  • 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
  • 6d3d479: 8272667: substandard error messages from the docs build
  • 73da66f: 8272318: Improve performance of HeapDumpAllTest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2021
@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@rkennke Pushed as commit f4be211.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants