Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272616: Strange code in java.text.DecimalFormat#applyPattern #5171

Closed

Conversation

@turbanoff
Copy link
Contributor

@turbanoff turbanoff commented Aug 18, 2021

remove redundant if


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272616: Strange code in java.text.DecimalFormat#applyPattern

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5171/head:pull/5171
$ git checkout pull/5171

Update a local copy of the PR:
$ git checkout pull/5171
$ git pull https://git.openjdk.java.net/jdk pull/5171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5171

View PR using the GUI difftool:
$ git pr show -t 5171

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5171.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

Loading

bplb
bplb approved these changes Aug 18, 2021
Copy link
Member

@bplb bplb left a comment

Looks fine.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272616: Strange code in java.text.DecimalFormat#applyPattern

Reviewed-by: bpb, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6d3d479: 8272667: substandard error messages from the docs build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb, @naotoj, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Aug 18, 2021
naotoj
naotoj approved these changes Aug 18, 2021
@turbanoff
Copy link
Contributor Author

@turbanoff turbanoff commented Aug 19, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@turbanoff
Your change (at version 7bf4559) is now ready to be sponsored by a Committer.

Loading

@bplb
Copy link
Member

@bplb bplb commented Aug 19, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

Going to push as commit 51c1b9a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
  • 6d3d479: 8272667: substandard error messages from the docs build

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@bplb @turbanoff Pushed as commit 51c1b9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@turbanoff turbanoff deleted the JDK-8272616_remove_repeated_check branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants