Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272674: Logging missing keytab file in Krb5LoginModule #5176

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Aug 18, 2021

The "Key for the principal foobar@acme.com not available in /home/foobar/foobar.keytab" debug output does not contain enough information. The keytab file might be missing, or not readable, or does not contain the required key(s).

Please note that this debug info is only visible when -Dsun.security.krb5.debug=true is added on the command line.

Fix is trivial. No new regression test needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272674: Logging missing keytab file in Krb5LoginModule

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5176/head:pull/5176
$ git checkout pull/5176

Update a local copy of the PR:
$ git checkout pull/5176
$ git pull https://git.openjdk.java.net/jdk pull/5176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5176

View PR using the GUI difftool:
$ git pr show -t 5176

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5176.diff

8272674: Logging missing keytab file in Krb5LoginModule
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2021
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 18, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2021

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Looks fine

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272674: Logging missing keytab file in Krb5LoginModule

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
  • 6d3d479: 8272667: substandard error messages from the docs build
  • 73da66f: 8272318: Improve performance of HeapDumpAllTest
  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 5189047: 8272558: IR Test Framework README misses some flags
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/2ed7b709a197f009632580b17e3b1df34c1ffeb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2021
@wangweij
Copy link
Contributor Author

wangweij commented Aug 19, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2021

Going to push as commit 9569159.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
  • 6d3d479: 8272667: substandard error messages from the docs build
  • 73da66f: 8272318: Improve performance of HeapDumpAllTest
  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/2ed7b709a197f009632580b17e3b1df34c1ffeb7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2021
@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@wangweij Pushed as commit 9569159.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8272674 branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants