Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command #518

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 6, 2020

The set-env command was recently deprecated in favor of a different method of setting environment variables, due to a security vulnerability [1]. The vulnerability does not affect our usage of GitHub Actions, but we should nevertheless update to avoid the associated deprecation warnings.

[1] https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/518/head:pull/518
$ git checkout pull/518

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 6, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title 8254054 8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command Oct 6, 2020
@openjdk openjdk bot added the rfr label Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Oct 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 6, 2020

Webrevs

Loading

edvbld
edvbld approved these changes Oct 6, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command

Reviewed-by: ehelin, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a34f48b: 8253832: CharsetDecoder : decode() mentioning CoderMalfunctionError behavior not as per spec
  • f397b60: 8251123: doclint warnings about missing javadoc tags and comments
  • c9d1dcc: 8253902: G1: Starting a new marking cycle before the conc mark thread fully completed causes assertion failure
  • 9199783: 8253565: PPC64: Fix duplicate if condition in vm_version_ppc.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 6, 2020
erikj79
erikj79 approved these changes Oct 6, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 6, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg Since your change was applied there have been 4 commits pushed to the master branch:

  • a34f48b: 8253832: CharsetDecoder : decode() mentioning CoderMalfunctionError behavior not as per spec
  • f397b60: 8251123: doclint warnings about missing javadoc tags and comments
  • c9d1dcc: 8253902: G1: Starting a new marking cycle before the conc mark thread fully completed causes assertion failure
  • 9199783: 8253565: PPC64: Fix duplicate if condition in vm_version_ppc.cpp

Your commit was automatically rebased without conflicts.

Pushed as commit d2b1dc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants