8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

[DamonFool]

Hi all,

May I get reviews for this small change?

The failure is caused by incorrect flag -mstack-alignment=16-DMAC_OS_X_VERSION_MIN_REQUIRED=10120.

The following command works fine with Xcode 12.0 but fails with Xcode 13.0.

clang++ -mstack-alignment=16-DMAC_OS_X_VERSION_MIN_REQUIRED=10120 a.cpp

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5180/head:pull/5180
$ git checkout pull/5180

Update a local copy of the PR:
$ git checkout pull/5180
$ git pull https://git.openjdk.java.net/jdk pull/5180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5180

View PR using the GUI difftool:
$ git pr show -t 5180

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5180.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6e1052e3)

[dholmes-ora]

Looks good - and I would say trivial, except I can't believe the original code has actually been doing what it was supposed to do, so the impact on things is less clear.

Thanks,
David

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Thanks @dholmes-ora .
/integrate

[openjdk]

Going to push as commit d007be0.
Since your change was applied there have been 9 commits pushed to the master branch:

• f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
• b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
• 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
• 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
• 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
• ab41812: 8272576: G1: Use more accurate integer type for collection set length
• 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
• 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit d007be0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.