Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled #5182

Closed
wants to merge 1 commit into from

Conversation

thejasviv
Copy link
Member

@thejasviv thejasviv commented Aug 19, 2021

Hi,

Please review this simple clean-up fix to remove an unused variable. The test passed on all platforms after this clean-up.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5182/head:pull/5182
$ git checkout pull/5182

Update a local copy of the PR:
$ git checkout pull/5182
$ git pull https://git.openjdk.java.net/jdk pull/5182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5182

View PR using the GUI difftool:
$ git pr show -t 5182

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5182.diff

…CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@thejasviv The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Aug 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • ddcd851: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • d007be0: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
  • f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
  • b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
  • 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
  • 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/6d3d47957ef03c90ed3b1cb7a48902366cd1bc27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 19, 2021
@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Aug 20, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

@thejasviv
Your change (at version c6d567f) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Aug 20, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

Going to push as commit 4bd37c3.
Since your change was applied there have been 11 commits pushed to the master branch:

  • ddcd851: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • d007be0: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
  • f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
  • b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
  • 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
  • 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
  • 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
  • ab41812: 8272576: G1: Use more accurate integer type for collection set length
  • 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/6d3d47957ef03c90ed3b1cb7a48902366cd1bc27...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

@akolarkunnu @thejasviv Pushed as commit 4bd37c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants