JDK-8272639: jpackaged applications using microphone on mac

[andyherrick]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272639: jpackaged applications using microphone on mac

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer) ⚠️ Review applies to e1f460e
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5186/head:pull/5186
$ git checkout pull/5186

Update a local copy of the PR:
$ git checkout pull/5186
$ git pull https://git.openjdk.java.net/jdk pull/5186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5186

View PR using the GUI difftool:
$ git pr show -t 5186

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5186.diff

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andyherrick The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (337e1fa1)
• 00: Full (e1f460e1)

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272639: jpackaged applications using microphone on mac

Reviewed-by: almatvee, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 9bc0232: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux
• 2ff4c01: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
• ad92033: 8272736: [JVMCI] Add API for reading and writing JVMCI thread locals
• 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
• 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
• 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
• d542745: 8267894: Skip work for empty regions in G1 Full GC
• 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

Should not it include the "application name" here? This is different from the java tool, where we do not know that info in advance.

[andyherrick]

Yes - I will revise with name substituted here.
I also considered localizing this string, but we only support localization of the tool, which would put string in the local that jpackage was run in, not the local the generated artifact was run in.

[andyherrick]

/integrate

[openjdk]

Going to push as commit b17b821.
Since your change was applied there have been 45 commits pushed to the master branch:

• 0e7288f: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions
• 6ace805: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
• c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
• aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
• d34f17c: 8270195: Add missing links between methods of JavaFX properties
• f608e81: 8264322: Generate CDS archive when creating custom JDK image
• f681d65: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
• 6e0328f: 8272725: G1: add documentation on needs_remset_update_t vs bool
• 2309b7d: 8253178: Replace LinkedList Impl in net.http.FilterFactory
• 94f5e44: 8271258: @param with non-ascii variable names produces incorrect results
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@andyherrick Pushed as commit b17b821.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.