8273910: Redundant condition and assignment in java.net.URI

[turbanoff]

1. Assignment ru.host = child.host; is duplicated and hence redundant.
2. Condition q > p is always true, because it just bellow inverse check

                if (q <= p)
                    break;

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273910: Redundant condition and assignment in java.net.URI

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5190/head:pull/5190
$ git checkout pull/5190

Update a local copy of the PR:
$ git checkout pull/5190
$ git pull https://git.openjdk.java.net/jdk pull/5190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5190

View PR using the GUI difftool:
$ git pr show -t 5190

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5190.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge]

Webrevs

• 00: Full (30003bce)

[dfuch]

I have sent this patch to our test system. I will come back with the results when they are available.

[dfuch]

The updated logic looks correct, and my tests (tier1,tier2,tier3) came back with no failure.
Reviewed.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273910: Redundant condition and assignment in java.net.URI

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 558 new commits pushed to the master branch:

• 5762ec2: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
• 4e960fe: 8274497: Unnecessary Vector usage in AquaFileSystemModel
• c833b4d: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
• d57fb6f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• 734d1fb: 8274211: Test man page that options are documented
• 9561fea: 8273102: Delete deprecated for removal the empty finalize() in java.desktop module
• 9945f7a: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management
• 754bc82: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml
• 4e7d7ca: 8273711: Remove redundant stream() call before forEach in jdk.jlink
• f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
• ... and 548 more: https://git.openjdk.java.net/jdk/compare/51c1b9a6870bd9644e92227e47082a53e2d1c066...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 30003bc) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 7de2cf8.
Since your change was applied there have been 566 commits pushed to the master branch:

• 8ca0846: 8274407: (tz) Update Timezone Data to 2021c
• 4ab274a: 8274858: Remove unused dictionary_classes_do functions
• 03a8d34: 8273826: Correct Manifest file name and NPE checks
• 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
• 340c715: 8273929: Remove GzipRandomAccess in heap dump test
• 8319836: 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy
• d5ccfa2: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
• 29dcbb7: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
• 5762ec2: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
• 4e960fe: 8274497: Unnecessary Vector usage in AquaFileSystemModel
• ... and 556 more: https://git.openjdk.java.net/jdk/compare/51c1b9a6870bd9644e92227e47082a53e2d1c066...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @turbanoff Pushed as commit 7de2cf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.