8272553: several hotspot runtime/CommandLine tests don't check exit code

[iignatev]

Hi all,

could you please review this patch that adds exit code check to several hotspot runtime/CommandLine tests?

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272553: several hotspot runtime/CommandLine tests don't check exit code

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 2c8bd63

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5191/head:pull/5191
$ git checkout pull/5191

Update a local copy of the PR:
$ git checkout pull/5191
$ git pull https://git.openjdk.java.net/jdk pull/5191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5191

View PR using the GUI difftool:
$ git pr show -t 5191

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5191.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (02fe85fd)
• 00: Full (2c8bd63c)

[dholmes-ora]

Hi Igor,

One test already has the check, but otherwise okay.

Thanks,
David

[dholmes-ora]

We are already testing the exit code.

[iignatev]

thanks for spotting that, removed.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272553: several hotspot runtime/CommandLine tests don't check exit code

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
• 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
• d542745: 8267894: Skip work for empty regions in G1 Full GC
• 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
• f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Thank you, David.

I've removed the redundant check from ConfigFileWarning.

-- Igor

/integrate

[openjdk]

Going to push as commit 709b591.
Since your change was applied there have been 26 commits pushed to the master branch:

• 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
• 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
• d542745: 8267894: Skip work for empty regions in G1 Full GC
• 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
• f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 709b591.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.