Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272553: several hotspot runtime/CommandLine tests don't check exit code #5191

Closed
wants to merge 3 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Aug 19, 2021

Hi all,

could you please review this patch that adds exit code check to several hotspot runtime/CommandLine tests?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272553: several hotspot runtime/CommandLine tests don't check exit code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5191/head:pull/5191
$ git checkout pull/5191

Update a local copy of the PR:
$ git checkout pull/5191
$ git pull https://git.openjdk.java.net/jdk pull/5191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5191

View PR using the GUI difftool:
$ git pr show -t 5191

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5191.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8272553 8272553: several hotspot runtime/CommandLine tests don't check exit code Aug 19, 2021
@openjdk openjdk bot added the rfr label Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Igor,

One test already has the check, but otherwise okay.

Thanks,
David

output.shouldNotHaveExitValue(0);
output.shouldContain("Unrecognized VM option 'aaa'");
output.shouldHaveExitValue(1);
Copy link
Member

@dholmes-ora dholmes-ora Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already testing the exit code.

Copy link
Member Author

@iignatev iignatev Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting that, removed.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272553: several hotspot runtime/CommandLine tests don't check exit code

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
  • 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
  • d542745: 8267894: Skip work for empty regions in G1 Full GC
  • 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • e8a289e: 8272609: Add string deduplication support to SerialGC
  • b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
  • f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • 04a806e: 8270344: Session resumption errors
  • d85560e: 8267161: Write automated test case for JDK-4479161
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 23, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Aug 23, 2021

Thank you, David.

I've removed the redundant check from ConfigFileWarning.

-- Igor

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

Going to push as commit 709b591.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
  • 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
  • d542745: 8267894: Skip work for empty regions in G1 Full GC
  • 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • e8a289e: 8272609: Add string deduplication support to SerialGC
  • b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
  • f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • 04a806e: 8270344: Session resumption errors
  • d85560e: 8267161: Write automated test case for JDK-4479161
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@iignatev Pushed as commit 709b591.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8272553 branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants