8272736: [JVMCI] Add API for reading and writing JVMCI thread locals

[tkrodriguez]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272736: [JVMCI] Add API for reading and writing JVMCI thread locals

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 60a1b4c
• Doug Simon (@dougxc - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5192/head:pull/5192
$ git checkout pull/5192

Update a local copy of the PR:
$ git checkout pull/5192
$ git pull https://git.openjdk.java.net/jdk pull/5192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5192

View PR using the GUI difftool:
$ git pr show -t 5192

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5192.diff

[bridgekeeper]

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkrodriguez The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fdddf672)
• 00: Full (60a1b4ca)

[vnkozlov]

Looks good.

Please, test before push.

[openjdk]

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272736: [JVMCI] Add API for reading and writing JVMCI thread locals

Reviewed-by: kvn, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 92bde67: 8271946: Cleanup leftovers in Space and subclasses
• db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
• a81e5e9: 8272654: Mark word accesses should not use Access API
• 4bd37c3: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
• ddcd851: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
• d007be0: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848
• f4be211: 8270041: Consolidate oopDesc::cas_forward_to() and oopDesc::forward_to_atomic()
• b40e8f0: 8271951: Consolidate preserved marks overflow stack in SerialGC
• 7eccbd4: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tkrodriguez]

testing was clean.

[tkrodriguez]

/integrate

[openjdk]

Going to push as commit ad92033.
Since your change was applied there have been 27 commits pushed to the master branch:

• 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
• 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
• 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
• d542745: 8267894: Skip work for empty regions in G1 Full GC
• 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
• b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
• e8a289e: 8272609: Add string deduplication support to SerialGC
• b690f29: 8269687: pauth_aarch64.hpp include name is incorrect
• f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
• 04a806e: 8270344: Session resumption errors
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tkrodriguez Pushed as commit ad92033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from coleen.phillimore at oracle.com on hotspot-dev:

On 8/23/21 2:27 PM, Tom Rodriguez wrote:

On Fri, 20 Aug 2021 15:24:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

Tom Rodriguez has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
src/hotspot/share/runtime/thread.hpp line 996:

994: return _jvmci_reserved1;
995: }
996:
This makes me reprise my wish that this code was in jvmciThread.hpp and you indirect from thread to there. Can you do that? There's already an RFE somewhere.
I hadn't forgotten about that but I have been putting it off a bit. I'll prioritize it. The RFE is https://bugs.openjdk.java.net/browse/JDK-8137018

Thank you!