Skip to content

Conversation

@a74nh
Copy link
Contributor

@a74nh a74nh commented Aug 20, 2021

Quick fix to correct the include guards.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269687: pauth_aarch64.hpp include name is incorrect

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5196/head:pull/5196
$ git checkout pull/5196

Update a local copy of the PR:
$ git checkout pull/5196
$ git pull https://git.openjdk.java.net/jdk pull/5196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5196

View PR using the GUI difftool:
$ git pr show -t 5196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5196.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2021

👋 Welcome back a74nh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@a74nh The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 20, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@a74nh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269687: pauth_aarch64.hpp include name is incorrect

Reviewed-by: rbackman, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rickard, @nick-arm) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 20, 2021
@a74nh
Copy link
Contributor Author

a74nh commented Aug 20, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@a74nh
Your change (at version 33f70f7) is now ready to be sponsored by a Committer.

@nick-arm
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2021

Going to push as commit b690f29.
Since your change was applied there have been 10 commits pushed to the master branch:

  • f77a1a1: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • 04a806e: 8270344: Session resumption errors
  • d85560e: 8267161: Write automated test case for JDK-4479161
  • 1ea437a: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 86add21: 8223923: C2: Missing interference with mismatched unsafe accesses
  • c701f6e: 8272739: Misformatted error message in EventHandlerCreator
  • fb1dfc6: 8267185: Add string deduplication support to ParallelGC
  • d874e96: 8271579: G1: Move copy before CAS in do_copy_to_survivor_space
  • 92bde67: 8271946: Cleanup leftovers in Space and subclasses
  • db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@nick-arm @a74nh Pushed as commit b690f29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants