8272472: StackGuardPages test doesn't build with glibc 2.34

[dholmes-ora]

Please review this simple test fix to address an issue that will prevent this test source from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.

Testing: local & mach5 tiers 1-3

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5200/head:pull/5200
$ git checkout pull/5200

Update a local copy of the PR:
$ git checkout pull/5200
$ git pull https://git.openjdk.java.net/jdk pull/5200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5200

View PR using the GUI difftool:
$ git pr show -t 5200

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5200.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f9d4f7ab)

[shipilev]

Looks fine. This is technically a memory leak, but we don't care much for the test code.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewed-by: shade, stuefe, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• 1ea437a: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• 86add21: 8223923: C2: Missing interference with mismatched unsafe accesses
• c701f6e: 8272739: Misformatted error message in EventHandlerCreator
• fb1dfc6: 8267185: Add string deduplication support to ParallelGC
• d874e96: 8271579: G1: Move copy before CAS in do_copy_to_survivor_space
• 92bde67: 8271946: Cleanup leftovers in Space and subclasses
• db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
• a81e5e9: 8272654: Mark word accesses should not use Access API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks for the review @shipilev . I thought about freeing again but it seemed pointless when the test is going to exit anyway.

[tstuefe]

Looks good. Leaking is fine here I think. I was confused about not having to cast till I remembered this is C.

[dholmes-ora]

Thanks for the review @tstuefe

[dholmes-ora]

/integrate

[openjdk]

Going to push as commit f77a1a1.
Since your change was applied there have been 10 commits pushed to the master branch:

• 04a806e: 8270344: Session resumption errors
• d85560e: 8267161: Write automated test case for JDK-4479161
• 1ea437a: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• 86add21: 8223923: C2: Missing interference with mismatched unsafe accesses
• c701f6e: 8272739: Misformatted error message in EventHandlerCreator
• fb1dfc6: 8267185: Add string deduplication support to ParallelGC
• d874e96: 8271579: G1: Move copy before CAS in do_copy_to_survivor_space
• 92bde67: 8271946: Cleanup leftovers in Space and subclasses
• db9834f: 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
• a81e5e9: 8272654: Mark word accesses should not use Access API

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit f77a1a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

Thanks for the review @DamonFool !

[dholmes-ora]

/backport jdk17u

[openjdk]

@dholmes-ora Unknown command backport - for a list of valid commands use /help.