Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272806: [macOS] "Apple AWT Internal Exception" when input method is changed #5211

Closed
wants to merge 1 commit into from
Closed

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Aug 22, 2021

There's a long eval in the bug report : https://bugs.openjdk.java.net/browse/JDK-8272806 but here's the summary

When focus is lost by the app a message is sent down to native setting a native reference to the input method to null
which is a sort of signal not to notify upwards anything to the input method (which internally will NPE if there's
no focused component as is the case after focus is lost).
But we aren't actually setting it to null because of a check for null which previously checked the wrapper for
the JNI ref was not null but is now obsolete. So just remove the check for null.

The steps to reproduce this bug are very manual and involve installing additional input methods and toggling them
at the system level. So I didn't see a way to write a useful regression test but if you follow the bug report steps you
should be able to verify the fix.

I've run all automated tests just for good measure and they all pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5211/head:pull/5211
$ git checkout pull/5211

Update a local copy of the PR:
$ git checkout pull/5211
$ git pull https://git.openjdk.java.net/jdk pull/5211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5211

View PR using the GUI difftool:
$ git pr show -t 5211

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5211.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 22, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 22, 2021

@prrace The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Aug 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 22, 2021

Webrevs

mrserb
mrserb approved these changes Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Reviewed-by: serb, dmarkov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 7f80683: 8272783: Epsilon: Refactor tests to improve performance
  • 22ef4f0: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame
  • 9bc0232: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux
  • 2ff4c01: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • ad92033: 8272736: [JVMCI] Add API for reading and writing JVMCI thread locals
  • 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
  • 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
  • d542745: 8267894: Skip work for empty regions in G1 Full GC
  • 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/f77a1a156f3da9068d012d9227c7ee0fee58f571...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 23, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Aug 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit f681d65.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@prrace Pushed as commit f681d65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt integrated
4 participants