Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272838: Move CriticalJNI tests out of tier1 #5219

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 23, 2021

See the bug report for more discussion. These tests are tied in Epsilon and Shenandoah test groups, so I rehashed those a bit. Note there are no tier2 or tier3 test groups in Hotspot yet, which means these tests would only run as part of Epsilon and Shenandoah test suites. I would rehash tier2/3 in JDK-8272914, while hooking up more runtime and GC tests there.

Motivational run time improvements:

$  make run-test TEST=hotspot:tier1

# Before
real	8m9.678s
user	289m59.304s
sys	27m46.347s

# After
real	7m53.359s    # 15 seconds saved
user	278m49.104s  # 11 minutes saved
sys	28m2.516s

Additional testing:

  • Checked hotspot:tier1 run test lists before/after the patch, the difference is only these two lists
  • Some test performance measurements.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5219/head:pull/5219
$ git checkout pull/5219

Update a local copy of the PR:
$ git checkout pull/5219
$ git pull https://git.openjdk.java.net/jdk pull/5219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5219

View PR using the GUI difftool:
$ git pr show -t 5219

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5219.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Aug 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 23, 2021

Webrevs

Loading

@shipilev shipilev changed the title 8272838: Remove CriticalJNI tests from tier1 8272838: Move CriticalJNI tests from tier1 Aug 23, 2021
@shipilev shipilev changed the title 8272838: Move CriticalJNI tests from tier1 8272838: Move CriticalJNI tests out of tier1 Aug 23, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Aleksey,

It was a bit hard to track the shuffling around but in the end this seems okay. :)

Thanks,
David

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272838: Move CriticalJNI tests out of tier1

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 596b075: 8258465: Headless build fails due to missing X11 headers on linux
  • a49a0c5: 8273062: Generation::refs_discovery_is_xxx functions are unused

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 27, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 27, 2021

It was a bit hard to track the shuffling around but in the end this seems okay. :)

Yes, test groups are kind of a maze (ing). I now realized that the affected tests are in tier2_epsilon and tier3_shenandoah, which means they would run in both prospective hotspot:tier2 and hotspot:tier3. I now moved the tests to tier2_shenandoah to match their tiers.

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 30, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

Going to push as commit f55d5ab.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a9188f2: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
  • 1fb798d: 8272915: (doc) package-info typo in extLink
  • 5116784: 8273091: Doc of [Strict]Math.floorDiv(long,int) erroneously documents int in @return tag
  • e66c8af: 8272866: java.util.random package summary contains incorrect mixing function in table
  • d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • a033aa5: 8273072: Avoid using += in configure
  • b92214a: 8272480: Remove Mutex::access rank
  • 596b075: 8258465: Headless build fails due to missing X11 headers on linux
  • a49a0c5: 8273062: Generation::refs_discovery_is_xxx functions are unused

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 30, 2021
@openjdk openjdk bot added integrated and removed ready labels Aug 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

@shipilev Pushed as commit f55d5ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Aug 30, 2021
@shipilev shipilev deleted the JDK-8272838-perf-test-criticaljni branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants