8272846: Move some runtime/Metaspace/elastic/ tests out of tier1

[shipilev]

See the bug report for more discussion. Attention @tstuefe -- is it time yet to do this?

Motivational run time improvements:

$  make run-test TEST=hotspot:tier1

# Before
real	8m9.678s
user	289m59.304s
sys	27m46.347s

# After
real	7m27.566s
user	284m4.947s
sys	27m33.724s

Additional testing:

• tier1 no longer runs these tests
• hotspot_tier2_runtime runs these tests

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272846: Move some runtime/Metaspace/elastic/ tests out of tier1

Reviewers

• Mikhailo Seledtsov (@mseledts - Committer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5222/head:pull/5222
$ git checkout pull/5222

Update a local copy of the PR:
$ git checkout pull/5222
$ git pull https://git.openjdk.java.net/jdk pull/5222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5222

View PR using the GUI difftool:
$ git pr show -t 5222

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5222.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c739a7f7)

[mseledts]

Change looks good to me, thank you. Good improvement in tier1 turn around time.

[tstuefe]

Looks good. They still would be run as part of tier2, right? Speaking of which, is there a description somewhere what the tiers mean and what the rules are for adding things to them?

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272846: Move some runtime/Metaspace/elastic/ tests out of tier1

Reviewed-by: mseledtsov, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 22ef4f0: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame
• 9bc0232: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux
• 2ff4c01: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
• ad92033: 8272736: [JVMCI] Add API for reading and writing JVMCI thread locals
• 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
• 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

They still would be run as part of tier2, right?

Unfortunately there is no hotspot:tier2 yet, I am adding them in JDK-8272914. I checked these tests run with hotspot_tier2_runtime, though, which should be the part of future hotspot:tier2.

[shipilev]

/integrate

[openjdk]

Going to push as commit ebd62bc.
Since your change was applied there have been 44 commits pushed to the master branch:

• 46684a4: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
• c925c7f: 8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array
• 76baace: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
• b16a04e: 8271186: Add UL option to replace newline char
• d732c30: 8272863: Replace usages of Collections.sort with List.sort call in public java modules
• fe7d708: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
• 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
• c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
• e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
• 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
• ... and 34 more: https://git.openjdk.java.net/jdk/compare/594e5161b48382d61509b4969bc8f52c3c076452...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit ebd62bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from David Holmes on hotspot-dev:

On 25/08/2021 2:29 am, Aleksey Shipilev wrote:

On Tue, 24 Aug 2021 05:41:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

They still would be run as part of tier2, right?

Unfortunately there is no `hotspot:tier2` yet, I am adding them in [JDK-8272914](https://bugs.openjdk.java.net/browse/JDK-8272914). I checked these tests run with `hotspot_tier2_runtime`, though, which should be the part of future `hotspot:tier2`.

Yeah probably an oversight. Our internal tier2 definition is the
combination of various hotspot_tier2_* groups plus some other stuff
(e.g. vector API testing). But there isn't a hotspot_tier2 group that
represents that.

David