Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong #5225

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Aug 23, 2021

Please review the fix to the subject issue. When instant seconds and zone co-exist in parsed data, instant seconds was not resolved correctly from them.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5225/head:pull/5225
$ git checkout pull/5225

Update a local copy of the PR:
$ git checkout pull/5225
$ git pull https://git.openjdk.java.net/jdk pull/5225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5225

View PR using the GUI difftool:
$ git pr show -t 5225

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5225.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 23, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Aug 23, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

Reviewed-by: joehw, rriggs, iris, lancea, scolebourne

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2021
Copy link
Contributor

@jodastephen jodastephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naotoj
Copy link
Member Author

naotoj commented Aug 26, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

Going to push as commit fe7d708.
Since your change was applied there have been 69 commits pushed to the master branch:

  • 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
  • c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
  • e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
  • b94fd32: 8272859: Javadoc external links should only have feature version number in URL
  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/96107e31dfe115fc102fa54d7bdd523c8a79ff76...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2021
@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@naotoj Pushed as commit fe7d708.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
6 participants